Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace features - App redirects to not here page when the feature is disabled #38896

Closed
1 of 6 tasks
kbecciv opened this issue Mar 24, 2024 · 7 comments
Closed
1 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37902
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > Collect workspace.
  3. Go to More features.
  4. Open the same page in Step 3 in a second tab.
  5. In the first tab, go to tab of enabled feature.
    6.. From the second tab, disable the feature in Step 5.
  6. Copy URL to any feature.
  7. Disable the feature in Step 7.
  8. Navigate to the URL of disabled feature.

Expected Result:

In Step 6, the first tab will redirect to More features page.
In Step 9, app will redirect to More features page.

Actual Result:

In Step 6, the first tab redirects to not here page.
In Step 9, not here page shows up.

Additional Information:

For Step 1-6, reproducible on web only.
For Step 7-9, reproducible in all environment.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Step 1-6

Bug6424478_1711214953624.Step_1_to_6.mp4

Step 7-9

Bug6424478_1711214953656.Step_7_to_9.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 24, 2024

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 24, 2024

We think that this bug might be related to #wave-control

@allgandalf
Copy link
Contributor

Looking at the conversation from #37902 it was later decided to show a not here page for the time being, so ig we can close this issue and NAB, isn't it @mountiny @getusha

@getusha
Copy link
Contributor

getusha commented Mar 24, 2024

That's right this was intentional.

@rezkiy37
Copy link
Contributor

It works properly. The app shows the "Not found" when a feature is disabled.

@luacmartins
Copy link
Contributor

Agree that this is the expected behavior. Closing.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants