Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Simplified Collect][More features] Unable to toggle on a feature when second tab is open #38897

Closed
4 of 6 tasks
kbecciv opened this issue Mar 24, 2024 · 15 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Mar 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37902
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace.
  • The Collect workspace has at least one feature that is disabled in More features.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > Collect workspace.
  3. Go to More features.
  4. Open the same page in Step 3 in a second tab and refresh the second tab.
  5. In the first tab, toggle on a disabled feature.
  6. Note that it is toggled back off and it shows not here page in the first tab.
  7. Close the second tab.
  8. Refresh the first tab.
  9. Toggle on the disabled feature.
  10. Note that now the feature can be toggled on without issue.

Expected Result:

In Step 5, app should successfully toggle on a disabled feature in the first tab when the second tab of the same page is open.

Actual Result:

In Step 5, when the second tab of the same page is open. app prevents from toggling on a disabled feature from the first tab.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424450_1711214502599.bandicam_2024-03-24_01-20-02-344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ac2f7c8241fff900
  • Upwork Job ID: 1772285151075995648
  • Last Price Increase: 2024-03-25
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 24, 2024

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 24, 2024

We think that this bug might be related to #wave-control

@kbecciv
Copy link
Author

kbecciv commented Mar 24, 2024

We think that this bug might be related to #wave-control

@luacmartins
Copy link
Contributor

I can take over since this is related to Simplified Collect. I'll demote this to NAB though since customers don't have access to this yet.

@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ac2f7c8241fff900

@melvin-bot melvin-bot bot changed the title WS features - Unable to toggle on a feature when second tab is open [$500] WS features - Unable to toggle on a feature when second tab is open Mar 25, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@luacmartins luacmartins changed the title [$500] WS features - Unable to toggle on a feature when second tab is open [$500] [Simplified Collect][More features] Unable to toggle on a feature when second tab is open Mar 25, 2024
@luacmartins luacmartins changed the title [$500] [Simplified Collect][More features] Unable to toggle on a feature when second tab is open [$250] [Simplified Collect][More features] Unable to toggle on a feature when second tab is open Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Upwork job price has been updated to $250

@trjExpensify
Copy link
Contributor

Open for proposals from the community here!

@luacmartins
Copy link
Contributor

luacmartins commented Mar 27, 2024

Still looking for proposals. Tagging @allroundexperts @DylanDylann @rezkiy37 @shubham1206agra since you all worked on More features issues and might have some context.

@rezkiy37
Copy link
Contributor

Sorry, I don't have the capacity to take the issue now. Can you confirm that the app used the staging server? I assume the production server is not ready to manipulate these toggles.
cc @waterim

@waterim
Copy link
Contributor

waterim commented Mar 28, 2024

I can take this!

@ArekChr
Copy link
Contributor

ArekChr commented Mar 28, 2024

It seems this bug appears to be no longer reproducible

@luacmartins
Copy link
Contributor

luacmartins commented Mar 28, 2024

Agree! I couldn't reproduce in dev anymore. Staging is still not updating in real time, but you can toggle the feature on/off with no issues. I think the real time sync will be fixed with the next deploy. Gonna close this one. Thanks for the help everyone!

web.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants