[HOLD for payment 2024-04-15] [TS migration] Migrate IOURequestStepDescription, IOURequestStepDate and IOURequestStepCurrency pages to TypeScript

[fabioh8010]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

• src/pages/iou/request/step/IOURequestStepDescription.js
• src/pages/iou/request/step/IOURequestStepDate.js
• src/pages/iou/request/step/IOURequestStepCurrency.js (it will be migrated here)

[fabioh8010]

This issue is internal and will be handled by the TS team.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

When you know who is handling it, let me know, have them comment and I'll assign. Switching to Weekly until then.

[bernhardoj]

We will migrate IOURequestStepCurrency in this issue. Currently on hold for this PR which replaces IOUCurrencySelection with IOURequestStepCurrency.

[fabioh8010]

Thanks for the info @bernhardoj!, so the updated list is this:

• src/pages/iou/request/step/IOURequestStepDescription.js
• src/pages/iou/request/step/IOURequestStepDate.js

[war-in]

Hi, I'm Marcin from Software Mansion and I'd like to work on this issue

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@lakchote] The PR that introduced the bug has been identified. Link to the PR:
• [@lakchote] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@lakchote] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@war-in] Determine if we should create a regression test for this bug.
• [@war-in] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[getusha]

@lakchote can you assign me here? ty!

[twisterdotcom]

@getusha did the PR review. Payment Summary:

• @war-in does not require payment (Contractor)
• @getusha paid $250 here

[twisterdotcom]

No need for checklist, this was a migration. Closing.

[getusha]

@twisterdotcom accepted the offer could you end the contract thanks!