[$250] [HOLD for payment 2024-04-05] [Simplified Collect][Taxes] - App crashes when opening Foreign currency default row after deleting the selected tax

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR : #38208

Version Number: 1.4.56-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is admin of Collect workspace.
• There are a few tax rates in the Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Taxes.
4. Click Settings > Foreign currency default > Select any tax rate.
5. Delete the tax rate selected in Step 4.
6. Click Settings > Foreign currency default.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6425851_1711367608184.20240325_194849.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e292bf5e67d0c666
• Upwork Job ID: 1776020973492867072
• Last Price Increase: 2024-04-04

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave-control.

[mountiny]

Happy to take over since its related to simplified collect

@ArekChr is going to look into this one

[ArekChr]

Sure, happy to handle this issue!

[kosmydel]

Hey, if needed we can check this issue as I with @filip-solecki was responsible for the Taxes feature. Just let me know, if we should investigate it.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - App crashes when opening Foreign currency default row after deleting the selected tax

What is the root cause of that problem?

The Onyx data is not updated correct

What changes do you think we should make in order to solve the problem?

Add the foreignTaxDefault, pendingFields and errorFields keys to the onyxData object here, as done in the setWorkspaceCurrencyDefault function

const onyxData: OnyxData = {
        optimisticData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    taxRates: {
                        foreignTaxDefault: policy?.taxRates?.defaultExternalID,
                        pendingFields: {foreignTaxDefault: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE},
                        errorFields: null,
                        taxes: taxesToDelete.reduce<TaxRateDeleteMap>((acc, taxID) => {
                            acc[taxID] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, errors: null};
                            return acc;
                        }, {}),
                    },
                },
            },
        ],
        successData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    taxRates: {
                        pendingFields: {foreignTaxDefault: null},
                        errorFields: null,
                        taxes: taxesToDelete.reduce<TaxRateDeleteMap>((acc, taxID) => {
                            acc[taxID] = null;
                            return acc;
                        }, {}),
                    },
                },
            },
        ],
        failureData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    taxRates: {
                        foreignTaxDefault: policy?.taxRates?.defaultExternalID,
                        pendingFields: {foreignTaxDefault: null},
                        errorFields: {foreignTaxDefault: ErrorUtils.getMicroSecondOnyxError('common.genericErrorMessage')},
                        taxes: taxesToDelete.reduce<TaxRateDeleteMap>((acc, taxID) => {
                            acc[taxID] = {
                                pendingAction: null,
                                errors: ErrorUtils.getMicroSecondOnyxError('workspace.taxes.errors.deleteFailureMessage'),
                            };
                            return acc;
                        }, {}),
                    },
                },
            },
        ],
    };

What alternative solutions did you explore? (Optional)

[luacmartins]

@ArekChr @filip-solecki are either of you available to investigate this one?

[filip-solecki]

Sure, I can check it!

[luacmartins]

Thanks! I think the solution involves:

1. Check if the taxes being deleted include the foreign tax default
2. If it does, we need to update the foreign tax default to the workspace default one
3. Update the pending action only for the foreign tax default field. The error will be shown on the deleted tax already, so no need to duplicate it here too

[luacmartins]

I'm gonna demote this from being a blocker since customers don't have access to this yet, but we should definitely fix it asap.

[filip-solecki]

@luacmartins You're right. What we have to do is just check if tax we want to remove is marked as Foreign tax default if yes we have to update it at the same time. In the Old Dot we have rule that the first tax from the list became Foreign tax default so do we want to keep it or do we want to use Workspace default tax?

[shahinyan11]

Doesn't anyone have any feedback on my proposal ?

[Ollyws]

Can I get assigned here for the C+ review? Thanks.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Simplified Collect][Taxes] - Fix for app crashing when opening Foreign currency default row after deleting the selected tax #38961

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)
• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$250 to @Ollyws

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e292bf5e67d0c666

[melvin-bot]

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@Ollyws - please apply to the job here:

https://www.upwork.com/jobs/~01e292bf5e67d0c666

Tomorrow, I can complete the payment process. Thanks!

[alexpensify]

@Ollyws - I sent an offer via Upwork, please accept and I can continue the payment process. Thanks!

[Ollyws]

Accepted, thanks.

[alexpensify]

Payouts due:

• Contributor: @filip-solecki Payment handled via the vendor
• Contributor+: $250 @Ollyws

Upwork job is here.

---

Closing, the payment process is complete in Upwork.