[$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Request money from the workspace chat.
4. Delete the workspace.
5. Click FAB.
6. Click Request money shortcut.

Expected Result:

After deleting the workspace, Request money shortcut should lead user to select a new participant.

Actual Result:

After deleting the workspace, Request money shortcut for the deleted workspace still remains. Clicking on the shortcut results in not here page.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6428615_1711540647403.shortcut_delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016af2ad690a3296e0
• Upwork Job ID: 1772979000228327424
• Last Price Increase: 2024-03-28

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #vip-vsb.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money shortcut for workspace remains after workspace is deleted

What is the root cause of that problem?

We don't check if workspace is archived before display the shortcut:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 338 to 343 in cd18bef

	...(props.quickAction && props.quickAction.action
	? [
	{
	icon: getQuickActionIcon(props.quickAction.action),
	text: translate(getQuickActionTitle(props.quickAction.action)),
	label: translate('quickAction.shortcut'),

What changes do you think we should make in order to solve the problem?

Add isArchivedRoom check

App/src/libs/ReportUtils.ts

Lines 1106 to 1108 in cd18bef

	function isArchivedRoom(report: OnyxEntry<Report> | EmptyObject): boolean {
	return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && report?.stateNum === CONST.REPORT.STATE_NUM.APPROVED;
	}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016af2ad690a3296e0

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[lakchote]

Related to #38669

cc @Gonals @parasharrajat

[parasharrajat]

Not a regression from the PR but a new case to be handled. That PR was only about adding the UI for quick action.

[habasefa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shortcut not being updated when a workspace related to the shortcut item is deleted

What is the root cause of that problem?

When a workspace is deleted, the shortcut(QuickAction) is not cleared.

What changes do you think we should make in order to solve the problem?

When a workspace is deleted checking if it is in quick action, if it is resetting quick action
Adding a code like

  let policyInQuickAction: string | undefined;
    Onyx.connect(
       { key: ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE,
        callback: (value)=> {
            policyInQuickAction = ReportUtils.getReportPolicyID(value?.chatReportID);
        },}
    )
    // Reset the quickAction policy
    if (policyID === policyInQuickAction){
        resetQuickAction();
    }

around here

App/src/libs/actions/Policy.ts

Lines 432 to 435 in 69a2849

	return Object.values(policies ?? {}).some((policy) => policy && policy.type === CONST.POLICY.TYPE.FREE && policy.role === CONST.POLICY.ROLE.ADMIN);
	}
	/**

and a code like this to clear the current quick action

/**
 * Reset quick action
 */
function resetQuickAction(){
    Onyx.set(ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE, null);
}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

[parasharrajat]

So Technically both proposals are a way forward.

1. We can either control showing the quick action when it is vague.
2. Or we can clear the quick action when the related report is archived.

Let me get my hands on design doc to understand the better approach.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting the workspace, Request money shortcut for the deleted workspace still remains. Clicking on the shortcut results in not here page.

What is the root cause of that problem?

We don't clear or hide the quick action when the report is archived or we cannot access to this report anymore

What changes do you think we should make in order to solve the problem?

1. In FloatingActionButtonAndPopover, we should subscribe the report of quickAction with id is quickAction.chatReportID

quickActionReport: {
    key: ({quickAction}) => `${ONYXKEYS.COLLECTION.REPORT}${lodashGet(quickAction, 'chatReportID', '0')}`
}

2. Add a useEffect that will clear the quickAction if the report is archived or it become undefined or we cannot access to this report anymore, we will clear the quickAction. That can cover all cases like we remove the user from workspace or we delete the workspace on another device, ....

useEffect(() => {
    if (!props.quickAction || !props.quickAction.chatReportID) {
        return;
    }

    if (!props.quickActionReport || ReportUtils.isArchivedRoom(props.quickActionReport)) {
        ReportActionUtils.clearQuickAction();
    }
}, [props.quickAction, props.quickActionReport])

3. Create a util function to clear the quickAction

function clearQuickAction() {
    Onyx.merge(ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE, null);
}

What alternative solutions did you explore? (Optional)

For point 2, we also can create a state to control the quickAction should be displayed or not and update this accordingly in the useEffect that is mentioned at point 2.

[parasharrajat]

Discussing this on Slack. https://expensify.slack.com/archives/C01GTK53T8Q/p1711646423775109

[mallenexpensify]

@parasharrajat can you share the Slack link plz?
I'm adding to #wave-collect cuz it's the earliest project that someone would encounter this bug.

[parasharrajat]

Added.

[parasharrajat]

Looks like the expected behaviour of this issue was incorrect which is updated. But we are also working on a follow-up issue/PR which should handle this issue as well. It is better to be held at #38051.

@mallenexpensify Could you please hold this issue on #38051

[mallenexpensify]

Thanks @parasharrajat , put on hold, removed Help Wanted and External

[trjExpensify]

Did we confirm with @Gonals that #38051 will take care of it?

I'm adding to #wave-collect cuz it's the earliest project that someone would encounter this bug.

@mallenexpensify more to the point, it's related to the Quick Action Button (QAB) project.

[parasharrajat]

@trjExpensify yes. expensify.slack.com/archives/C01GTK53T8Q/p1711646423775109

[trjExpensify]

Dope!

[lakchote]

PR got approved, waiting for another reviewer's approval to be merged.

[mallenexpensify]

PR is on main
#39413

[parasharrajat]

@Expensify/applause Can we please retest it?

[mallenexpensify]

Taking off hold, added retest-weekly label.

[trjExpensify]

I think this is probably the same as: #41467

We have a PR up for that, so this can be closed. @Gonals can confirm though!

[Gonals]

Yep! This should be handled by #41474

[trjExpensify]

Excellllent. Another one bites the dust!