-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted #39051
Comments
Triggered auto assignment to @mallenexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @lakchote ( |
@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think that this bug might be related to #vip-vsb. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Request money shortcut for workspace remains after workspace is deleted What is the root cause of that problem?We don't check if workspace is archived before display the shortcut: App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js Lines 338 to 343 in cd18bef
What changes do you think we should make in order to solve the problem?Add Lines 1106 to 1108 in cd18bef
What alternative solutions did you explore? (Optional)N/A |
Job added to Upwork: https://www.upwork.com/jobs/~016af2ad690a3296e0 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak ( |
Related to #38669 |
Not a regression from the PR but a new case to be handled. That PR was only about adding the UI for quick action. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Shortcut not being updated when a workspace related to the shortcut item is deleted What is the root cause of that problem?When a workspace is deleted, the shortcut(QuickAction) is not cleared. What changes do you think we should make in order to solve the problem?When a workspace is deleted checking if it is in quick action, if it is resetting quick action
around here App/src/libs/actions/Policy.ts Lines 432 to 435 in 69a2849
and a code like this to clear the current quick action
What alternative solutions did you explore? (Optional) |
Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new. |
So Technically both proposals are a way forward.
Let me get my hands on design doc to understand the better approach. |
ProposalPlease re-state the problem that we are trying to solve in this issue.After deleting the workspace, Request money shortcut for the deleted workspace still remains. Clicking on the shortcut results in not here page. What is the root cause of that problem?We don't clear or hide the quick action when the report is archived or we cannot access to this report anymore What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)For point 2, we also can create a state to control the quickAction should be displayed or not and update this accordingly in the useEffect that is mentioned at point 2. |
Discussing this on Slack. https://expensify.slack.com/archives/C01GTK53T8Q/p1711646423775109 |
@parasharrajat can you share the Slack link plz? |
Added. |
Looks like the expected behaviour of this issue was incorrect which is updated. But we are also working on a follow-up issue/PR which should handle this issue as well. It is better to be held at #38051. @mallenexpensify Could you please hold this issue on #38051 |
Thanks @parasharrajat , put on hold, removed |
Did we confirm with @Gonals that #38051 will take care of it?
@mallenexpensify more to the point, it's related to the Quick Action Button (QAB) project. |
Dope! |
PR got approved, waiting for another reviewer's approval to be merged. |
PR is on main |
@Expensify/applause Can we please retest it? |
Taking off hold, added |
Yep! This should be handled by #41474 |
Excellllent. Another one bites the dust! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
After deleting the workspace, Request money shortcut should lead user to select a new participant.
Actual Result:
After deleting the workspace, Request money shortcut for the deleted workspace still remains. Clicking on the shortcut results in not here page.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6428615_1711540647403.shortcut_delete.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: