Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - When opening a request and going back, the requests list is displayed empty #39609

Closed
1 of 6 tasks
izarutskaya opened this issue Apr 4, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): bellicoignacio@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open the https://staging.new.expensify.com
  2. Open any chat that contains requests.
  3. Tap on the requests preview.
  4. Open any request from the list displayed.
  5. Tap on the arrow on the top left corner.
  6. Check the requests list behaviour.
  • Sometimes you need to relog-in to see the issue

Expected Result:

The requests list, should remain visible when opening one and returning to previous page.

Actual Result:

After opening one request and tapping on the arrow to go back to previous page, the requests list is displayed empty.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6437555_1712204086223.Requests.mp4

Bug6437555_1712204086303!Requests

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@miljakljajic I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

Production

Screen_Recording_20240404_170111_Chrome.mp4

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2024

cc @NikkiWines as it might be still related to the one transaction view

Noting that the production deploy did not work this morning so the current production is actually 2 releases back from current staging (hence the one transaction PR is not in production yet)

@NikkiWines
Copy link
Contributor

NikkiWines commented Apr 4, 2024

Pretty sure this is the same underlying issue as #39461 which we determined was not due to a front-end change (though we still don't know the root cause) but rather a bug related previousReportActionIDs erroneously being set to 0

@luacmartins
Copy link
Contributor

Cool, so it seems like we can close this in favor of #39461?

@NikkiWines
Copy link
Contributor

At the very least it's not a blocker, buuuuuttttt... I'd love your help on #39461 if you have the bandwidth 🙇

Rory summarized our findings from yesterday here. I'm not very familiar with our pusher logic and why we're not passing the correct previousReportActionID even though OpenReport is returning the right value.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@luacmartins luacmartins added the Reviewing Has a PR in review label Apr 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@luacmartins
Copy link
Contributor

PR is in review.

Copy link

melvin-bot bot commented Apr 15, 2024

@luacmartins, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Apr 17, 2024

@luacmartins, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Apr 19, 2024

@luacmartins, @miljakljajic 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Apr 23, 2024

@luacmartins, @miljakljajic 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Apr 25, 2024

@luacmartins, @miljakljajic 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

This issue has not been updated in over 14 days. @luacmartins, @miljakljajic eroding to Weekly issue.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

This issue has not been updated in over 15 days. @luacmartins, @miljakljajic eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@luacmartins
Copy link
Contributor

This was fixed a while ago, but the automation didn't close the issue. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants