Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD - EApp #20354] Start chat - No hover effect on Add to group button #39625

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 4, 2024 · 13 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Request money > Manual
  3. Enter amount and proceed to contact list
  4. Hover over split button
  5. Go to FAB > Start chat > Chat
  6. Hover over Add to group button

Expected Result:

There will be hover effect on Add to group button

Actual Result:

There is no hover effect on Add to group button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438139_1712245526515.20240404_234032.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@neonbhai
Copy link
Contributor

neonbhai commented Apr 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Start chat - No hover effect on Add to group button

What is the root cause of that problem?

We disable default hover from the custom list button here:

shouldUseDefaultHover={false}

What changes do you think we should make in order to solve the problem?

We should enable it,

  • By Adding a custom prop, or
  • By Enabling button hover all usecases (since button hovering is standard for E/App, we can test and enable for all components using this)

@nkdengineer
Copy link
Contributor

It should be held for #38610

@alexpensify alexpensify changed the title Start chat - No hover effect on Add to group button [HOLD - EApp #20354] Start chat - No hover effect on Add to group button Apr 5, 2024
@alexpensify
Copy link
Contributor

Thanks for flagging @nkdengineer. @rushatgabhane I see you are the C+ for the issue mentioned here. Do you agree with this hold? Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@alexpensify
Copy link
Contributor

No update yet, waiting for confirmation if we should move this to Weekly and keep it on hold.

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@alexpensify
Copy link
Contributor

Still waiting for feedback here.

@rushatgabhane
Copy link
Member

@alexpensify yes i think it's fine to hold here

@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2024
@trjExpensify
Copy link
Contributor

Why did this get put into #wave-collect? It's a bug in Start Chat.

@alexpensify
Copy link
Contributor

My mistake @trjExpensify

@dragnoir
Copy link
Contributor

This issue is fixed within #38610

@alexpensify
Copy link
Contributor

Thank you for that update, I'm going to close this GH then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants