Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-09] [$250] [Search v1] Create SearchTableHeader #39876

Closed
luacmartins opened this issue Apr 9, 2024 · 15 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Apr 9, 2024

Section from design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015e5d2a642d33771a
  • Upwork Job ID: 1780985200188256256
  • Last Price Increase: 2024-04-18
Issue OwnerCurrent Issue Owner: @anmurali
@luacmartins luacmartins added the Daily KSv2 label Apr 9, 2024
@luacmartins luacmartins self-assigned this Apr 9, 2024
@luacmartins luacmartins changed the title [Search v1] Create SearchTableHeader [HOLD][Search v1] Create SearchTableHeader Apr 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Apr 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2024
@WojtekBoman
Copy link
Contributor

Hi! I'm going to work on that :)

@luacmartins luacmartins changed the title [HOLD][Search v1] Create SearchTableHeader [Search v1] Create SearchTableHeader Apr 18, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. External Added to denote the issue can be worked on by a contributor labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [Search v1] Create SearchTableHeader [$250] [Search v1] Create SearchTableHeader Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015e5d2a642d33771a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 18, 2024
@luacmartins luacmartins added Weekly KSv2 Daily KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@luacmartins
Copy link
Contributor Author

@WojtekBoman is still working on this

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2024
@luacmartins
Copy link
Contributor Author

Still in dev

Copy link

melvin-bot bot commented Apr 29, 2024

@anmurali, @hungvu193, @luacmartins, @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

Draft PR is up and actively being worked on.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 29, 2024
@luacmartins
Copy link
Contributor Author

I'm merging the PR above since SWM will be ooo for the rest of the week and the functionality is not yet available to users. I'll continue to work on it myself in the meantime.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 1, 2024
@hungvu193
Copy link
Contributor

hungvu193 commented May 2, 2024

@luacmartins Oh I saw you already found some C+ to review the PR, so I'm unassigning my self.

@hungvu193 hungvu193 removed their assignment May 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 2, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v1] Create SearchTableHeader [HOLD for payment 2024-05-09] [$250] [Search v1] Create SearchTableHeader May 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 2, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@WojtekBoman] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 3, 2024
@anmurali
Copy link

anmurali commented May 6, 2024

I don't think there's any payment that needs to be issued here. Closing.

@anmurali anmurali closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants