[Hold for payment Aug 23rd] InlineCode block is trimmed on Android

[parasharrajat]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performe

1. Open any conversation on E.cash on Mobile App.
2. Send following message.

This is a big message which includes `inline code block`. An inline code block can be `two lines long and we have to make sure that it is shown correctly`. 

Expected Result:

The code block is trimmed and not visible correctly.

Actual Result:

Describe what actually happened

Code block should be visible correctly.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None.

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: Latest
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Sorry for posting a draft PR before Triaging but that PR is added to track issue status.

[parasharrajat]

This issue needs attention. Thank you.

[conorpendergrast]

Ah, sorry I missed this, it wasn't showing up correctly for me until today. I'll get someone to reproduce this on Android (I'm on iOS) and will have them post in here!

[conorpendergrast]

Asked for reproduction again

[laurenreidexpensify]

Okay so tested this on Android mweb - and had no issues

then on Android app and managed to replicate -

My font size is set to large, so to test against that I reduced it to smallest and got this -

[conorpendergrast]

Great, thanks for testing that out Lauren!

[MelvinBot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[NikkiWines]

Looks like a good candidate for UpWork! Adding the External label

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

I already made one PR for the fix which was needed ATM for another issue #4006.

Proposal

1. We have to adjust the styling for the inline code block on Android. Recent changes of RN Text to Expensi-Text caused this breakdown.

[trjExpensify]

Any news on that, @parasharrajat?

[parasharrajat]

Still waiting for library side fix but I am ready to move forward with my solution just waiting for one more PR to be merged in the codebase #4503

[trjExpensify]

Thank you! 👍

[MelvinBot]

@johnmlee101, @trjExpensify, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

PR is approved. Just need to be merged.

[iwiznia]

There was a regression here #4733 @parasharrajat can you take a look please?

[parasharrajat]

Yup. Sure

[parasharrajat]

@iwiznia even reverting this PR does not fix this issue. This issue is caused by upgrading the react-native-render-html. And I am tracking multiple issues caused by that here meliorence/react-native-render-html#514.

[iwiznia]

Right, scratch that back then, this issue had no regressions. Sorry about that @parasharrajat

[trjExpensify]

Can we close this issue again then, Gents?

[parasharrajat]

It is yet to be paid so it's fine if this is open.

[MelvinBot]

@johnmlee101, @trjExpensify, @parasharrajat Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@johnmlee101, @trjExpensify, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

@johnmlee101, @trjExpensify, @parasharrajat 10 days overdue. Is anyone even seeing these? Hello?

[johnmlee101]

Has this been paid?

[trjExpensify]

I've been OoO. Paid today!