Android - Workspace- App crashes when change workspace Avatar

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4489531&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers): gocemate+balto963@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open New dot app
2. Login with gmail account
3. Create Workspace
4. Go to workspace profile> Upload photo
5. Select any photo from device

Expected Result:

Avatar should be successfully uploaded

Actual Result:

App crashes when change workspace Avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445721_1712830604847.Recording__2836.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

@lanitochka17 Can you attach the logs?

[lanitochka17]

@ShridharGoel Hello
log1.txt

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Android, app crashes when change workspace avatar. It happens once in a while (not happening each time).

What is the root cause of that problem?

This is happening because of a race condition in react-native-reanimated which is fixed here: software-mansion/react-native-reanimated#5759

This fix is available in 3.8.0.

We have mentioned the version of react-native-reanimated as ^3.7.2 with the caret but in package-lock.json it isn't updated to 3.8.0 / 3.8.1

https://github.com/Expensify/App/blob/e8c57de54628939ee05133c24124a051b56b3f41/package-lock.json#L31459-L31478

What changes do you think we should make in order to solve the problem?

Update the version of react-native-reanimated to 3.8.1 which is the latest stable version.

What alternative solutions did you explore? (Optional)

A patch can also be added with the needed changes from software-mansion/react-native-reanimated#5759.

But updating the dependency version would be better. We can also update to 3.9.0-rc.0.

[adelekennedy]

I can't replicate on BrowserStack, Expensify v.1.4.62-4, I think this has been fixed

[ShridharGoel]

@adelekennedy This is not fixed, it's just difficult to replicate (happens once in a while). But I think it's still something that users might be facing on some occasions, so can we attempt to fix it?