Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link #40467

Closed
6 tasks done
m-natarajan opened this issue Apr 18, 2024 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a task.
  3. Go to task report.
  4. Add a single line link description in format.
  5. Note that the link in system message is not underlined.
  6. Change the description to multiline link.
  7. Note that the link in system message is now underlined.
  8. Right click on the link in the system message.

Expected Result:

In Step 5, the single line link in the system message will be underlined.
In Step 8, right clicking on the link in the system message will invoke "Copy URL to clipboard" option.

Actual Result:

In Step 5, the single line link in the system message is not underlined.
In Step 8. right clicking on the link in the system message invoke context menu for the entire system message, instead of "Copy URL to clipboard" option for the link.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453471_1713437346723.20240418_183009.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a44464a57aff770b
  • Upwork Job ID: 1781092961225887744
  • Last Price Increase: 2024-04-24
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 18, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #vip-vsb

@m-natarajan
Copy link
Author

We think this bug might be related to #vip-vsb

@miljakljajic
Copy link
Contributor

@jasperhuangg what do you think - definitely a deploy blocker? I think this could be worked on externally, right?

@jasperhuangg
Copy link
Contributor

Seems like a pretty minor bug and doesn't need to be a blocker

@jasperhuangg
Copy link
Contributor

It looks like something that wasn't taken into consideration in #40200, I think we should get the author of the PR to fix this @bernhardoj

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 18, 2024

I don't think we need to treat this as a regression from #39496 (so we don't need to dock pay), since it wasn't originally included in the requirements for the issue it was solving #39496. But I think @bernhardoj should still fix it for the sake of consistency across all types of links.

@jasperhuangg jasperhuangg added the External Added to denote the issue can be worked on by a contributor label Apr 18, 2024
@melvin-bot melvin-bot bot changed the title Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link [$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a44464a57aff770b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@jasperhuangg jasperhuangg changed the title [$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link Apr 18, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 19, 2024
@mallenexpensify mallenexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Apr 24, 2024
@melvin-bot melvin-bot bot changed the title Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link [$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2024
@mallenexpensify
Copy link
Contributor

@eh2077 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks. I see Reviewing here but unsure what the linked PR is

@bernhardoj
Copy link
Contributor

@mallenexpensify this is a missing case from my PR, so we are handling it here

@eh2077
Copy link
Contributor

eh2077 commented Apr 24, 2024

@bernhardoj Can you also link this issue in PR #40625? So that we can track this issue together.

@eh2077
Copy link
Contributor

eh2077 commented Apr 24, 2024

Unassign myself since the fix PR #40625 is already ongoing.

@eh2077 eh2077 removed their assignment Apr 24, 2024
@bernhardoj
Copy link
Contributor

Done

Copy link

melvin-bot bot commented May 1, 2024

@miljakljajic, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented May 3, 2024

@miljakljajic, @jasperhuangg Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented May 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented May 18, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants