-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link #40467
Comments
Triggered auto assignment to @jasperhuangg ( |
Triggered auto assignment to @miljakljajic ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. We think this bug might be related to #vip-vsb |
We think this bug might be related to #vip-vsb |
@jasperhuangg what do you think - definitely a deploy blocker? I think this could be worked on externally, right? |
Seems like a pretty minor bug and doesn't need to be a blocker |
It looks like something that wasn't taken into consideration in #40200, I think we should get the author of the PR to fix this @bernhardoj |
I don't think we need to treat this as a regression from #39496 (so we don't need to dock pay), since it wasn't originally included in the requirements for the issue it was solving #39496. But I think @bernhardoj should still fix it for the sake of consistency across all types of links. |
Job added to Upwork: https://www.upwork.com/jobs/~01a44464a57aff770b |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
@eh2077 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks. I see |
@mallenexpensify this is a missing case from my PR, so we are handling it here |
@bernhardoj Can you also link this issue in PR #40625? So that we can track this issue together. |
Unassign myself since the fix PR #40625 is already ongoing. |
Done |
@miljakljajic, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@miljakljajic, @jasperhuangg Huh... This is 4 days overdue. Who can take care of this? |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
In Step 5, the single line link in the system message will be underlined.
In Step 8, right clicking on the link in the system message will invoke "Copy URL to clipboard" option.
Actual Result:
In Step 5, the single line link in the system message is not underlined.
In Step 8. right clicking on the link in the system message invoke context menu for the entire system message, instead of "Copy URL to clipboard" option for the link.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6453471_1713437346723.20240418_183009.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: