-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mWeb/Safari - UI - The top part of the UI is white while the page is loading in dark mode #40683
Comments
Triggered auto assignment to @grgia ( |
Triggered auto assignment to @johncschuster ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
This is minor ui bug, lets not block deploy on this given we are close to shipping it |
@izarutskaya is this reproducible on the previous version? |
ProposalPlease re-state the problem that we are trying to solve in this issue.The status bar of the mobile web (safari) is white instead of following the splash screen color. What is the root cause of that problem?The status bar color is based on the Line 7 in 76d6539
Since the value is empty, it just follows the device theme. The status bar is then updated depends on the page every time the nav state changes. App/src/components/CustomStatusBarAndBackground/index.tsx Lines 63 to 115 in 76d6539
What changes do you think we should make in order to solve the problem?Set |
@grgia do you need us to check if it's still repro on the current build ? |
Job added to Upwork: https://www.upwork.com/jobs/~01a67f702d8230d48e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
the PR is already deployed to staging a few days ago. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@getusha, can you complete the BZ Checklist when you get a moment? |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-28. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@getusha can you address the BZ Checklist when you get a moment? Thank you! |
@getusha bump on the checklist! 🙏 |
Payment Summary@bernhardoj requires payment automatic offer (Contributor) - PAID |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a It seems like we missed an edge case after implementing the dark mode. I was able to reproduce this on older builds. |
@johncschuster I will request the payment in newdot |
@getusha Great! Thanks for your contributions! |
I chatted with @getusha via Slack DM, and it sounds like we're going to continue paying through Upwork on issues assigned to them before 2024-05-25. (cc @mallenexpensify) I'm going to pay this one via Upwork. |
This has now been paid. Thanks, everyone! |
Whoops. I didn't mean to reopen this. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/Expensify/issues/302570
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition: Dark mode should be enabled.
Expected Result:
The whole UI should be in dark mode.
Actual Result:
The top part of the UI is white while the page is loading in dark mode. The issue appears when refreshing any room, or chat, or LHN and when you kill and re-open Safari.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6456678_1713720715815.KRDX1564.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @johncschusterThe text was updated successfully, but these errors were encountered: