Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #40845] LHN - HTML displayed in LHN when sending markdown message with attachment #41141

Closed
3 of 6 tasks
lanitochka17 opened this issue Apr 27, 2024 · 7 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in in Gmail account
  3. Go to chat and write a message with markdown
  4. Click the plus sign and select attachment
  5. Send the attachment with the message. Notice in the LHN, the HTML is displayed

Expected Result:

When sending a markdown message with an attachment, the LHN should not display the message with HTML

Actual Result:

When sending a markdown message with an attachment, the LHN displays the message with HTML

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463669_1714216456821.Screen_Recording_2024-04-27_at_3.51.15_AM.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 27, 2024
Copy link

melvin-bot bot commented Apr 27, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@allgandalf
Copy link
Contributor

#40845 should fix this, @sakluger let's put this on hold :)

@twisterdotcom twisterdotcom changed the title LHN - HTML displayed in LHN when sending markdown message with attachment [HOLD on #40845] LHN - HTML displayed in LHN when sending markdown message with attachment Apr 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger
Copy link
Contributor

Thanks @GandalfGwaihir!

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Apr 30, 2024
@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@sakluger
Copy link
Contributor

I tested myself and this seems to be fixed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants