Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Workspace members do not trigger notification after being invited to the room #41313

Closed
2 of 6 tasks
izarutskaya opened this issue Apr 30, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Version 1.4.68-0 (1.4.68-0)
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : #39313
Email or phone of affected tester (no customers): applausetester+yuriy.28.apr.new.admin@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1 . Create a workspace room
2. Invite a workspace member to the room
3. Invite a non-workspace member to the room
4. Check chat and LHN preview for the notifications

Expected Result:

The user should be able to see all notifications about members invited to the room
Expected to see 2 users in the LHN and 2 notifications in the chat

Actual Result:

Only Non-worksacpe members are counted in the LHN panel preview and are indicated in the chat notification after invitation.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6466170_1714448536392.pr_check.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@francoisl
Copy link
Contributor

cc @dukenv0307 @DylanDylann if you could take a look please, this was noticed when testing #39313.

@melvin-bot melvin-bot bot added the Overdue label May 2, 2024
Copy link

melvin-bot bot commented May 3, 2024

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dukenv0307
Copy link
Contributor

web-resize.mp4

@jasperhuangg Please check the InviteToRoom api. It is currently not returning anything when inviting user already in the workspace to a room.

@jasperhuangg
Copy link
Contributor

@dukenv0307 yes, that is expected. We do nothing if you try to invite a user already in the room.

@dukenv0307
Copy link
Contributor

@jasperhuangg I mean the user is already in the workspace and not yet in the room

@jasperhuangg
Copy link
Contributor

@dukenv0307 Ah sorry for misunderstanding. This behavior is currently expected based on what we have in the back-end. When someone is in a workspace, they can join the workspace room of their own free will, so we don't notify when they are invited to the room.

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants