-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Editing comment with image attachment fails to load the image when cache expires #42206
Comments
Triggered auto assignment to @jliexpensify ( |
@m-natarajan you've tagged the wrong person. cc @mallenexpensify |
Job added to Upwork: https://www.upwork.com/jobs/~018082d3734c0fe3cf |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
Labeled internally and added to #vip-vsb cuz it doesn't have to do with money. All yours JLi |
@rushatgabhane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue, waiting on an Engineer to pick this up. |
@rushatgabhane @jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Not overdue |
@rushatgabhane, @jliexpensify Huh... This is 4 days overdue. Who can take care of this? |
internal. not overdue |
🎀 👀 🎀 assign internal |
Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Sorry, I don't have bandwidth to take this, unassigning! |
Not overdue |
@mjasikowski will help out here 💪 |
Assigned! |
FInally have time to dig into this. |
was able to repro still Screen.Recording.2024-09-25.at.10.12.04.mp4 |
Current findings:
|
There's a draft expensify-common PR now adding attribute caching support to |
It turns out that only expensify-common fix is enough, and that's ready in Expensify/expensify-common#808 |
PR still under review |
https://github.com/Expensify/Web-Expensify/pull/43729 was needed after all, submitted that too |
Hi @mjasikowski - just a heads up to let you know I'll be OOO from the 3rd to 14th. I'll prep a Payment Summary, I think this is all that's needed from me:
|
@m-natarajan the fix is now on both staging and production, can you re-test? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1715767781452439
Action Performed:
LINK: https://staging.new.expensify.com/r/5708510475809890
Expected Result:
Editing a comment, clearing cache, and reloading the page should display the comment and the image attachment.
Actual Result:
Clearing cache and reloading shows the comment and a placeholder box instead of the image attachment.
More details here: #41952 (comment)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
330751938-58ed8062-5520-41f2-a971-dc291af9956f.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: