[$250] [HOLD for payment 2024-06-13] [QBO] Amend the account type available to configure on reimbursable exports to be relevant to the selected export option

[zanyrenney]

Problem:

The copy used for reimbursable exports inconsistently refers to all selections as choosing an A/P account, instead of showing the QBO accounts that should be shown per export choice.

Additionally, the page's copy always mentions vendor bills, regardless of whether a check or journal entry is selected for export.
Lastly, we're only showing explainer text for vendor bills, meaning there is not consitency in the design as there are no similar explanations for checks or journal entries (this is different from oldDot where we use the full explainers on the export page.

Solution: Update the QBO accounts available to chosen depending on the export choice to:

Vendor Bill:

Notes for completeness:

• Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized vendor bill for each Expensify report. If the period of the bill is closed, we'll post to the 1st of the next open period. You can add the vendor bill to your A/P account of choice (below).
• Update the push input label depending on the export selection (in this case, Accounts Payable)
  Update copy on screen 2:
  Copy should read: "This is your chosen A/P account, against which vendor bills for each report are created."

Journal Entry:

Notes for completeness:

• Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized journal entry for each Expensify report. You can post the offset entry to your account of choice (below).
• Update the push input label depending on the export selection (in this case, Account)
• Screen 2: Copy should read: "This is your chosen account to post the journal entry offset for each report."

Check:

Notes for completeness:

• Update copy on screen 1: Export out-of-pocket expenses as page copy should read We'll create a single itemized check for each Expensify report. You can write the check from your bank account of choice (below).
• Update the push input label depending on the export selection (in this case, Bank account)
• Copy should read: "This is your chosen bank account to write checks from."

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014665d08c6cbedbca
• Upwork Job ID: 1801670785370229018
• Last Price Increase: 2024-06-14

[hunxjunedo]

kindly provide details about reproducing the issue, and the platforms which are affected by it.

[melvin-bot]

📣 @hunxjunedo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

Conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1716465257860679?thread_ts=1716238564.568549&cid=C036QM0SLJK

[trjExpensify]

Solution: Update the QBO accounts available to chosen depending on the export choice to:
Vendor bill = accountPayableAccounts only
Check = bankAccounts
Journal Entry = (a few different QBO accountTypes are available here)

@zanyrenney the account types being made available for selection are correct for each export type chosen, it's the copy, labelling and so on which is incorrect. The purpose of this was to illustrate why it's incorrect to always be referring to vendor bills and AP account selection.

[zanyrenney]

I think the rest of the issue is correct though right? I'll just remove that bit, I was trying to add more context from the slack thread, but let me get that cleaned up @trjExpensify

[s77rt]

Raised a PR. Need translation #42524 (comment)

[trjExpensify]

I think the rest of the issue is correct though right? I'll just remove that bit, I was trying to add more context from the slack thread, but let me get that cleaned up @trjExpensify

Yeah sorry, it's just this title gave the impression that the proposed solution was to change the accounts being made available to choose, which is the one thing that's actually not being changed. 😅 Rest is good!

Solution: Update the QBO accounts available to chosen depending on the export choice to:

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• QBO: Add explicit description for each export entity #42548

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist does not apply. Not a bug, more like a feature request / add missed implementation

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014665d08c6cbedbca

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[zanyrenney]

please apply to job @s77rt https://www.upwork.com/jobs/~014665d08c6cbedbca

[s77rt]

@zanyrenney Applied!

[zanyrenney]

hired you - with offer - please accept.

[s77rt]

@zanyrenney Accepted! Thanks!

[zanyrenney]

Payment Summary

https://www.upwork.com/jobs/~014665d08c6cbedbca

• ROLE: @s77rt paid $250 via Upwork

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[zanyrenney]

all done here, thanks @s77rt