Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in - Unable to Google/Apple sign in #42807

Closed
1 of 6 tasks
m-natarajan opened this issue May 29, 2024 · 10 comments
Closed
1 of 6 tasks

Sign in - Unable to Google/Apple sign in #42807

m-natarajan opened this issue May 29, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.77-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2661814
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition: user has google and apple id accounts.

  1. Open desktop app
  2. Click on the Apple (or Google) button
  3. Enter or select Apple (or Google) account
  4. When redirected to a browser tab, click on pop-up to open desktop app

Expected Result:

User is signed in with an Apple (or Google) account.

Actual Result:

Sign in page opens again.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495365_1717004209996.google_apple_login.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 29, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 29, 2024
@mountiny
Copy link
Contributor

This was a backend blocker and its now resolved.

@mountiny mountiny added the DeployBlockerCash This issue or pull request should block deployment label May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

Current assignee @roryabraham is eligible for the DeployBlockerCash assigner, not assigning anyone new.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

Coming from this thread https://expensify.slack.com/archives/C049HHMV9SM/p1717069114614249?thread_ts=1717054355.084129&cid=C049HHMV9SM this seems to be broken for desktop

QA is verifying if this is repro in production too

@mountiny mountiny reopened this May 30, 2024
@joekaufmanexpensify
Copy link
Contributor

Discussing in the slack thread

@roryabraham
Copy link
Contributor

Currently trying to get this set up to test locally. The documentation has lots of detailed but no straightforward set of instructions. Going to figure it out and hopefully improve the documentation along the way

@roryabraham
Copy link
Contributor

Closing this as it's fixed

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants