Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags - Delete pop-up briefly appears expanded at the bottom after deleting tag #42886

Closed
2 of 6 tasks
kavimuru opened this issue May 31, 2024 · 13 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.78-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4587700&group_by=cases:section_id&group_id=296081&group_order=asc
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings
  3. Go to Tags,
  4. Add a tag.
  5. Delete the tag.

Expected Result:

Delete pop-up will disappear after deleting the tag.

Actual Result:

Delete pop-up briefly appears expanded at the bottom after deleting the tag.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6496891_1717113065975.tag_tag_tag_tag_tag.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kavimuru
Copy link
Author

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@Krishna2323
Copy link
Contributor

Regression from #36292

@Christinadobrzyn
Copy link
Contributor

hey @roryabraham and @getusha can you check out this to see if it's a regression from #36292

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@neil-marcellini neil-marcellini added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlocker Indicates it should block deploying the API labels Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

Current assignee @robertjchen is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Christinadobrzyn
Copy link
Contributor

Dmd @getusha and @roryabraham to check on this

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
@robertjchen robertjchen removed the DeployBlockerCash This issue or pull request should block deployment label Jun 4, 2024
@robertjchen robertjchen added Daily KSv2 and removed Hourly KSv2 labels Jun 4, 2024
@getusha
Copy link
Contributor

getusha commented Jun 4, 2024

Screen.Recording.2024-06-04.at.8.58.43.in.the.morning.mov

@Christinadobrzyn I am unable to reproduce this on staging

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jun 4, 2024

Thanks for retesting @getusha! I'm also not able to reproduce this. I'm going to see if QA can test. https://expensify.slack.com/archives/C9YU7BX5M/p1717489962405439

@kavimuru
Copy link
Author

kavimuru commented Jun 4, 2024

@Christinadobrzyn not able to reproduce.

bandicam.2024-06-04.20-14-17-436.mp4

@Christinadobrzyn
Copy link
Contributor

Awesome! Let's close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants