[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] Unable to open composer + menu and FAB menu after refreshing RHP

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Click on the chat header.
4. Refresh the page while RHP is open.
5. Click outside the RHP to dismiss it.
6. Click + button next to the composer.
7. Click FAB button.

Expected Result:

Menu will open when clicking on composer + button and FAB button after refreshing RHP.

Actual Result:

Menu does not open when clicking on composer + button and FAB button after refreshing RHP.
Also, right-click menu also does not open after refreshing RHP.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6497147_1717143395892.20240531_161415.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[izarutskaya]

production

bandicam.2024-05-31.12-28-28-568.mp4

[bernhardoj]

Same root cause as #42911

[danieldoglas]

I think the proposals in #42911 will fix this, so I'm not exporting it.

[danieldoglas]

Removing deploy blocker since this was not caused by API changes, leaving deployblcokercash.

[Julesssss]

I think the proposals in #42911 will fix this, so I'm not exporting it.

FYI we don't have a solution for this yet. We have a proposal but need more eyes on this as this is the only remaining blocker

[roryabraham]

@danieldoglas why did you make this a Daily? Since it's still a deploy blocker, it should be Hourly. It's also on HOLD for something that's not a deploy blocker, which doesn't really make sense priority-wise.

[danieldoglas]

@roryabraham The issue this was linked to (#42911) was demoted as a deploy blocker today after I added HOLD on this one. The solutions being discussed there were gonna solve the issues being described here, which is why I didn't think it made sense to put both as external.

[mountiny]

QA confirmed this is fixed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Use modal context provider to fix useResponsiveLayout #43013

If no regressions arise, payment will be issued on 2024-06-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@danieldoglas / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@danieldoglas / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@danieldoglas / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@danieldoglas / @roryabraham] Determine if we should create a regression test for this bug.
• [@danieldoglas / @roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Use modal context provider to fix useResponsiveLayout #43013

If no regressions arise, payment will be issued on 2024-06-13. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@danieldoglas / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@danieldoglas / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@danieldoglas / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@danieldoglas / @roryabraham] Determine if we should create a regression test for this bug.
• [@danieldoglas / @roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[roryabraham]

C+ payment due to @hoangzinh for this one.

[MitchExpensify]

Reminder set to pay

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@danieldoglas, @hoangzinh, @MitchExpensify, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Upwork never created the job, here is a manually created job for payment @hoangzinh https://www.upwork.com/jobs/~011cb0e8991e9f2353

[hoangzinh]

Accepted. Thanks @MitchExpensify

[MitchExpensify]

Contract ended and paid, thanks @hoangzinh