[HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4597262
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

precondition: location access is disabled

1. Open the app and log in
2. Tap the FAB > Submit expense >Distance
3. Select do not allow on the pop-up and wait for the map to load
4. Tap the start point and select Use current location
5. Allow location access

Expected Result:

The blue dot is displayed as user's current location and replaces the start point on the map

Actual Result:

The blue dot is still displayed over San Francisco while the start point is set to the current location

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6502239_1717554700706.video_2024-06-04_22-29-07.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194e3d6c394ce03d6
• Upwork Job ID: 1798364343763573802
• Last Price Increase: 2024-06-12
• Automatic offers:
• fedirjh | Reviewer | 102783101
• ZhenjaHorbach | Contributor | 102783102

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[dangrous]

Yep, this seems like it should be external! I'll try to look into it to but open to proposals. I didn't see an obvious PR that would have caused it but will investigate.

@m-natarajan this doesn't happen on production, correct?

[dangrous]

Oh wait lol there is an obvious PR - #40759 - let me review.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194e3d6c394ce03d6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[nkdengineer]

• IMO, I don't think this bug is related to PR because as we can see in the OP, the blue dot (current location) and the 1st waypoint are very far apart, so that is why the blue dot cannot replace the start point on the map.

I am still investigating the RCA ...

[neil-marcellini]

@dangrous thanks for adding the external label. In the future please also remove the DeployBlocker label when doing so, to signal that we don't need to block the Web deploy.

[sakluger]

Yeah let's get another C+ volunteer and assign them manually. I'll post in Slack!

[ZhenjaHorbach]

I can help with review !

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[sakluger]

The automation thinks that @ZhenjaHorbach is the Contributor and @fedirjh is the C+, and there's no easy way to change it, so we'll just remember that it's the other way around.

[melvin-bot]

@dangrous @sakluger @fedirjh @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dangrous]

just noting for my own purposes since it's been a while - the PR is merged and on staging, hasn't yet gone to prod.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Blue dot is not displayed over current user location #44023

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment automatic offer (Reviewer)
• @ZhenjaHorbach requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@fedirjh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

Unfortunately, I didn’t find the PR that introduced the bug
But on the other side, all the changes in this PR are more related to code refactoring

• [@fedirjh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

• [@fedirjh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@fedirjh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@fedirjh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open the app and log in
2. Tap the FAB -> Submit expense -> Distance
3. Select do not allow on the pop-up and wait for the map to load
4. Tap the start point and select Use current location
5. Allow location access
6. Verify blue dot is displayed as the user's current location

Do we agree 👍 or 👎

[sakluger]

@fedirjh I withdrew the Upwork offer since you can now request payment via NewDot. I'll post the payment summary below.

[sakluger]

Summarizing payment on this issue:

Contributor: @fedirjh $250, please request on Newdot
Contributor+: @ZhenjaHorbach $250, paid via Upwork

[JmillsExpensify]

$250 approved for @fedirjh