[HybridApp] Switch to Expensify Classic values are not cleared out

[AndrewGable]

Problem

1. Clicking Switch to Expensify Classic twice does not have the values cleared
2. When the values are not cleared when opening the survey again

Solution

Always clear the "Please tell us why you are leaving" data when switching from NewDot to OldApp

Issue Owner

Current Issue Owner: @staszekscp

[AndrewGable]

cc @staszekscp

[AndrewGable]

Posted a discussion for my proposed solution: https://expensify.slack.com/archives/C03TQ48KC/p1717622781938369

tl;dr we should move to API.makeRequestWithSideEffects instead of write to let the request finish before closing react native.

[staszekscp]

Hey! I'll post a PR for this today :)

[AndrewGable]

BTW we got agreement that we can use makeRequestWithSideEffects here if needed 👍

[staszekscp]

Thanks! The code is ready, I just need to record videos, and I’m going to finish that tomorrow 😅

[AndrewGable]

Merged the PR, making a TestFlight now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [HybridApp] Change switchToOldDot to return a promise #43275

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @staszekscp does not require payment (Contractor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [HybridApp] Change switchToOldDot to return a promise #43275

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @staszekscp does not require payment (Contractor)

[AndrewGable]

@cead22 is having this issue again, I think I saw it happen again once too. Mind double checking it @staszekscp?

RPReplay_Final1724247548.MP4

[staszekscp]

Sure! Do we have any logs that would indicate if the request failed or hanged?

[AndrewGable]

I believe that it's the same front end issue that happened in the past where the request isn't even started because the values are there before the user entered them.