Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v1] Search - "Nothing to show" label is missing if you create an empty report in OD #43389

Closed
3 of 6 tasks
m-natarajan opened this issue Jun 10, 2024 · 7 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #43192
Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: no , new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/

  2. ND: Log in with a new expensifail account

  3. ND: Create a workspace

  4. Navigate to https://staging.expensify.com/

  5. OD: Log in with the same expensifail account

  6. OD: Create an empty report

  7. ND: Navigate to Search - Shared

Expected Result:

The label should be visible.

Actual Result:

"Nothing to show" label is missing if you create an empty report in OD. It's visible in all of the other tabs under Search.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6508145_1718030050712.bandicam_2024-06-10_16-32-13-440.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@luacmartins luacmartins changed the title Search - "Nothing to show" label is missing if you create an empty report in OD [Search v1] Search - "Nothing to show" label is missing if you create an empty report in OD Jun 10, 2024
@luacmartins
Copy link
Contributor

In this case we're still returning the empty report to App. Confirming if we want to display the empty report or the empty state component
Screenshot 2024-06-10 at 10 40 27 AM

@luacmartins
Copy link
Contributor

The fix for this is in Auth, so NAB.

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
@luacmartins
Copy link
Contributor

This should be fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants