Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-07-23] [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted #43407

Closed
4 of 6 tasks
lanitochka17 opened this issue Jun 10, 2024 · 26 comments
Closed
4 of 6 tasks

[HOLD for payment 2024-07-23] [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted #43407

lanitochka17 opened this issue Jun 10, 2024 · 26 comments
Assignees
@luacmartins @lschurr @adamgrzybowski @getusha
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 10, 2024 •
edited by luacmartins
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.81-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to workspace chat
  3. Submit an expense
  4. Go to Search
  5. Tap on the submitted expense
  6. Tap on the header subtitle to return to the main chat
  7. Tap on the back button

Expected Result:

If app is meant to return to the Inbox tab, the Inbox tab should be highlighted

Actual Result:

App returns to LHN (Inbox), but the Search tab is highlighted instead.
When selecting a workspace from the workspace switcher, the interface changes to Search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6508403_1718040129733.RPReplay_Final1718039873.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b7ac090e7d716f56
  • Upwork Job ID: 1800231443819400029
  • Last Price Increase: 2024-06-10
  • Automatic offers:
    • getusha | Reviewer | 102765943
Issue OwnerCurrent Issue Owner: @lschurr
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@NikkiWines NikkiWines added Weekly KSv2 Hourly KSv2 and removed Hourly KSv2 labels Jun 10, 2024
@luacmartins luacmartins removed the DeployBlocker Indicates it should block deploying the API label Jun 10, 2024
@NikkiWines NikkiWines removed the Weekly KSv2 label Jun 10, 2024
@luacmartins luacmartins changed the title Search - App returns to LHN from transaction thread in Search while Search is highlighted [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted Jun 10, 2024
@github-actions github-actions bot mentioned this issue Jun 10, 2024
Closed
@luacmartins
Copy link
Contributor

Demoting to NAB. @adamgrzybowski @Kicu could you please take a look?

@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b7ac090e7d716f56

@melvin-bot melvin-bot bot changed the title [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted Jun 10, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@adamgrzybowski adamgrzybowski mentioned this issue Jun 19, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 19, 2024
@adamgrzybowski
Copy link
Contributor

Okay, there was slight delay but it's ready 😄 @WojtekBoman is currently reviewing the changes

@laurenreidexpensify laurenreidexpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Jun 20, 2024
@laurenreidexpensify laurenreidexpensify removed their assignment Jun 20, 2024
@laurenreidexpensify laurenreidexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 20, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 20, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 20, 2024
@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Jun 20, 2024
@laurenreidexpensify
Copy link
Contributor

@lschurr handing this one over for parental leave cover. We're in review for the PR, so this will just be handling payment. thanks!

@kavimuru kavimuru mentioned this issue Jun 24, 2024
Closed
@kbecciv kbecciv mentioned this issue Jul 10, 2024
Closed
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 15, 2024

This issue has not been updated in over 15 days. @luacmartins, @lschurr, @adamgrzybowski, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@adamgrzybowski
Copy link
Contributor

I think this one is done

@luacmartins
Copy link
Contributor

Yes, PR deployed to prod on Jul 16. Updating the issue.

@luacmartins luacmartins changed the title [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted [HOLD for payment 2024-07-23] [$250] [Search v1] - App returns to LHN from transaction thread in Search while Search is highlighted Jul 22, 2024
@luacmartins luacmartins added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 Reviewing Has a PR in review labels Jul 22, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 23, 2024 •
edited
Loading

Payment summary:

@lschurr lschurr closed this as completed Jul 23, 2024
@JmillsExpensify
Copy link

$250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@lschurr lschurr

@adamgrzybowski adamgrzybowski

@getusha getusha

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests