[HOLD for payment 2024-08-09] [Workspace Feeds] [External] Add a support for new system messages

[mountiny]

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

[melvin-bot]

@MariaHCD, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

Later phase of implementation

[mountiny]

@koko57 will work on this one

[mountiny]

Will be picked up soon

[koko57]

@mountiny same here- should we wait for the backend?

[mountiny]

yes

[trjExpensify]

Updated the title to reflect the hold on #407836

[koko57]

@trjExpensify this one should be on hold 😃 #44317 - @mountiny has already updated the title. This one - I can start working on it

[mountiny]

Yeah I think there is actually not many changes for this one and they do not have to be on hold, will update the title

[trjExpensify]

Great, let's do it then!

[koko57]

@mountiny @shawnborton these messages will appear in the Workspace chat or in a chat with the user we're assigning the card? I've noticed one thing:
for the CARDISSUED and CARDMISSINGADDRESS we're showing the assignee name, whereas for the CARDISSUEDVIRTUAL we're showing "You" instead of the user's name.



I think we should stick to the one pattern, if it's a direct message to the user assigned maybe it would be better to go with "You" (no logic for user name and pronouns would be required). If it would be a workspace message visible to other users we have to go with the name though.

[trjExpensify]

I agree they should be consistent. I think we wanted to use a mention to GBR the chat for the user being issued a card for added awareness.

I totally agree with not using "You" or including gender specific copy that needs to be "pronoun aware". CC: @kevinksullivan not sure why we did that really, it seems unnecessarily complex.

[trjExpensify]

these messages will appear in the Workspace chat or in a chat with the user we're assigning the card?

Oh, and yes, these messages are posted in the workspace chat of the member being assigned a card. 👍

[koko57]

@trjExpensify thanks! So we're going with pattern:
a

or b

[trjExpensify]

A! There can me other people in the workspace chat.

[kevinksullivan]

Agree with the cionsistency, I think that was an oversight on my part. Here is alternative copy we can use to avoid pronouns/"you", while keeping the mention:

Issued @kevin an Expensify Card! The card will be shipped once a mailing address is added.

Issued @kevin an Expensify Card! The card will arrive in 2-3 business days.

Issued @kevin a virtual %Expensify Card%! The card can be used right away.

[mountiny]

This is non-core issue so focusing elsewhere

[melvin-bot]

@MariaHCD, @koko57, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@MariaHCD, @koko57, @mountiny Still overdue 6 days?! Let's take care of this!

[mountiny]

Keeping this open until we get this tested in full stack

[mountiny]

Focusing on getting the core issues in and then tackling this

[melvin-bot]

@MariaHCD, @koko57, @mountiny Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

This is being tackled on this week

[melvin-bot]

@MariaHCD, @koko57, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

We are working on cleaning up these messages

[mountiny]

We need to still update slightly the message in BE so not closing

[mountiny]

I wonder what is left to do here, we have tested the report actions already so maybe we can close this one 🤔 @MariaHCD @trjExpensify

[trjExpensify]

Yeah, what did you mean by this though?

We need to still update slightly the message in BE so not closing

[mountiny]

Right, sometimes I do mean things I write, the auth messages do not have the mentions in them.

Gonna make a PR for it

[mountiny]

PR is ready and we can close it after https://github.com/Expensify/Auth/pull/12579

[trjExpensify]

Dope, deployed, closing!