[HOLD for payment 2024-07-10] [$250] [Search v1] "Description" is clickable but does not sort the expenses

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44181
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Account has no any expenses (new account).

1. Go to staging.new.expensify.com
2. Submit two expenses to any user with different description and no merchant.
3. Go to Search.
4. Wait for two transactions to show up.
5. Click on the description.

Expected Result:

The expenses can be sorted by description, since description is clickable.

Actual Result:

The expenses cannot be sorted by description, even though description is clickable.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6524639_1719356162097.20240626_065219.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d3c62ae3fec778ff
• Upwork Job ID: 1805898588572242732
• Last Price Increase: 2024-06-26

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[Julesssss]

Based on this issue which has only just been merged, this sounds like an edge case when we don't have any merchant details. I am removing the blocker labels and have raised the bug in both the issue and the PR in order to help with the follow-up fix:

• Fix should show merchant #44181
• [$250] [HOLD for payment 2024-07-10] [Search v1] Description doesn't show if merchant is always empty #44180

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d3c62ae3fec778ff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - "Description" is clickable but does not sort the expenses

What is the root cause of that problem?

We don't have sorting property defined for description:

App/src/libs/SearchUtils.ts

Line 29 in 0c20881

[CONST.SEARCH.TABLE_COLUMNS.DESCRIPTION]: null,

What changes do you think we should make in order to solve the problem?

Add desc: string; in TransactionListItemType.

Then, in getTransactionsSections in SearchUtils, get the description and return it with the other properties:

const description = TransactionUtils.getDescription(transactionItem);

return {
    ...transactionItem,
    from,
    to,
    formattedFrom,
    formattedTo,
    formattedTotal,
    formattedMerchant,
    date,
    shouldShowMerchant,
    shouldShowCategory: metadata?.columnsToShow.shouldShowCategoryColumn,
    shouldShowTag: metadata?.columnsToShow.shouldShowTagColumn,
    shouldShowTax: metadata?.columnsToShow.shouldShowTaxColumn,
    keyForList: transactionItem.transactionID,
    shouldShowYear: doesDataContainAPastYearTransaction,
    desc
};

Update sorting property to this:

[CONST.SEARCH.TABLE_COLUMNS.DESCRIPTION]: 'desc' as const,

What alternative solution did you explore?

We can prevent description from being clickable, like tax is not clickable.

[luacmartins]

We already have description available. We should just extend the sorting functionality to allow for nested objects.

[luacmartins]

PR here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix description sort #44472

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [Search v1] Add sorting  #42248
• The offending PR has been commented on: [Search v1] Add sorting  #42248 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @s77rt owed $250 via NewDot

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805898588572242732/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary above is accurate. $250 to @s77rt for PR review. I assume that you'll be submitting this via New Expensify?

[s77rt]

@JmillsExpensify Yes. Just did!

[JmillsExpensify]

Going to close this then! I need a payment summary from Matt Allen, and asked him via DM.

[mallenexpensify]

Contributor+: @s77rt due $250 via NewDot

[JmillsExpensify]

$250 approved for @s77rt