Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 30th July, 2024] [CSV] Support Export CSV on native NewDot apps #45511

Closed
rlinoz opened this issue Jul 16, 2024 · 7 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Jul 16, 2024

This is a follow up to #44576

Problem: Because of the lib we use to download files on mobile native we can't export the CSV file the same way we do it for web, since the lib doesn't allow a request body.

https://github.com/RonRadtke/react-native-blob-util/tree/master#:~:text=Download%20Manager%20can%20only%20support%20GET%20method%2C%20which%20means%20the%20request%20body%20will%20be%20ignored.

Problem: Find a way to download the CSV on the native apps.

@rlinoz rlinoz changed the title Support Export CSV on native NewDot apps [CSVSupport Export CSV on native NewDot apps Jul 16, 2024
@rlinoz rlinoz changed the title [CSVSupport Export CSV on native NewDot apps [CSV] Support Export CSV on native NewDot apps Jul 16, 2024
@trjExpensify trjExpensify added the Daily KSv2 label Jul 16, 2024
@trjExpensify
Copy link
Contributor

@filip-solecki can you comment on this issue so we can assign it to you as well?

@filip-solecki
Copy link
Contributor

HI! I am Filip from SWM and I'd like to work on this!

@trjExpensify
Copy link
Contributor

@rushatgabhane assigning you for C+ if we need it here.

@trjExpensify trjExpensify added the NewFeature Something to build that is a new item. label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 18, 2024
@trjExpensify trjExpensify changed the title [CSV] Support Export CSV on native NewDot apps [Awaiting Payment 30th July, 2024] [CSV] Support Export CSV on native NewDot apps Jul 23, 2024
@trjExpensify trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Jul 23, 2024
@trjExpensify
Copy link
Contributor

PR hit prod 5 hours ago, updating the title and labels to reflect the prod hold for payment.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Jul 25, 2024
@trjExpensify
Copy link
Contributor

Confirming payment as follows:

Regression tests have been added centrally for this project. Feel free to go ahead and request, Rushat. Closing!

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants