[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-09] Optimize frontend performance in most recent mode

[neil-marcellini]

Problem

For moderate to large accounts like @JmillsExpensify's, the app frequently hangs and lags when doing basic actions like approving reports, pinning reports, etc. We know this performance should be better, but is it possible to optimize it only on the frontend, or do we also need to implement pagination to return less total reports.

Solution

Profile the app when it's lagging to see where the most time is being spent and how we might improve it. Determine if optimizations will be sufficient or if pagination is required.

We have started investigating Jason's app performance in this thread.

cc @marcaaron @adhorodyski

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[adhorodyski]

Hi, I'd like to work on this:)

[allgandalf]

Can someone please assign me here for the C+ review, thanks

[ishpaul777]

please assingn me too for #46500

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @adhorodyski is from an agency-contributor and not due payment
• ROLE: @mkhutornyi paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allgandalf]

Can you pay me for this review @dylanexpensify , thanks

[dylanexpensify]

On it now, apologies!

[ishpaul777]

me too for #46500 : )

[adhorodyski]

I think we can close this one since we've started creating separate issues for the performance related PRs recently?

[allgandalf]

I guess i’m still due payment here 😬

[mkhutornyi]

I guess i’m still due payment here 😬

#46519

[allgandalf]

opps, Let me check upwork once to match that issue

[ishpaul777]

I am still due payment btw 😄

[dylanexpensify]

@ishpaul777 were you reviewer here?
@mkhutornyi were you paid?

[ishpaul777]

yes! I reviewed #46500 which was linked to this PR

[mkhutornyi]

I am not paid yet.

I reviewed these PRs linked to this issue:
#46409
#46886
#47229
#47147

[dylanexpensify]

Roger! Paying today!

[dylanexpensify]

Payment summary:

Contributor+: @ishpaul777 $250
Contributor+: @mkhutornyi $1,000
Contributor+: @allgandalf $250

Please apply/request!

[dylanexpensify]

Please apply here!

[ishpaul777]

@dylanexpensify could you please send in the offer. DMed you my upwork profile, i have no upwork connects to apply to job.

[dylanexpensify]

BTW sent offer @ishpaul777, invite to @mkhutornyi, @allgandalf mind applying?

[dylanexpensify]

@mkhutornyi @allgandalf sent offers!

[dylanexpensify]

Upwork being glitchy for me, attempting again today!

[dylanexpensify]

Done!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.