-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-01] [$125] [HIGH] [API Reliability] Opening the Wallet page calls the OpenPaymentsPage twice #45754
Comments
Triggered auto assignment to @mallenexpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Opening the Wallet page calls the OpenPaymentsPage twice What is the root cause of that problem?The root cause of this problem is the presence of two separate App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx Lines 276 to 278 in c1881ed
App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx Lines 289 to 294 in c1881ed
What changes do you think we should make in order to solve the problem?We can remove this one an only trigger the What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~015c4debdbfd2eca47 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Upwork job price has been updated to $125 |
This is a simple change, @nyomanjyotisa proposal is looking good, assigning |
📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@nyomanjyotisa what is your ETA for the PR? |
I will create a PR right now |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-01. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Contributor: @nyomanjyotisa paid $125 via Upwork @thesahindia plz complete the BZ checklist above. |
https://github.com/Expensify/App/pull/22412/files#r1701365475
Not needed
Not needed |
@mallenexpensify, @mountiny, @nyomanjyotisa, @thesahindia Huh... This is 4 days overdue. Who can take care of this? |
@thesahindia if you propose we don't want a regression test case, can you provide reasoning why you think we don't need one? For this, I'm assuming it's because |
It was a very specific issue. We added the same code twice and because of that we were calling the api twice. |
$125 approved for @thesahindia |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721384323190839
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
The OpenPaymentsPage read call is made only once
Actual Result:
Describe what actually happened
The API was called twice
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: