Track expense-App crashes when submitting a track expense to someone

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4764744
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Login with a new gmail account
2. Navigate to the Self DM
3. Click on the + on the compose box
4. Choose Track expense
5. Create a manual expense of any amount
6. On the actionable whisper options of the track expense, click on "Submit to someone"
7. When you are brought to the participant selector, start typing an email address

Expected Result:

User is able to select an email address and finish the flow of submitting to someone

Actual Result:

App crashes

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552370_1721895866499.2024-07-25_11_13_10.mp4

Bug6552370_1721896458336!staging.new.expensify.com-1721896427037.txt

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #vip-vsb

[MariaHCD]

Was able to reproduce the bug on staging, looks like the API call to SearchForReports failed, in my case it worked for the first few times but then later errored and returned no response:

Internal logs

[NikkiWines]

I can reproduce it on dev, but found this PR on the most recent deploy that literally aims to fix this bug #45994

Given that I don't think this is a web deploy blocker (or even a newDot blocker, I just think the bug is not wholly fixed.

[nkdengineer]

I don't think this issue comes from my PR because it doesn't change the money request flow.

[NikkiWines]

Weirdly, I'm no longer able to reproduce this on staging or dev 🤔

[nkdengineer]

I tried and was also not able to reproduce this bug.

[NikkiWines]

Asked for a re-test here

[m-natarajan]

Tester is able to reproduce the bug. Attaching new video and it is happening only in gmail acounts

2024-07-25.20.52.46.mp4

[francoisl]

Can't reproduce either locally. The console error in the video above points to this line, though the surrounding code hasn't been changed in a while.
I wonder if it's a backend issue though, like some API command changed the response format for a whisper report action and no longer includes a resolution?

[NikkiWines]

Oh, good thinking @francoisl. @tgolen, I see you in the code for some of the logic related to resolution in the whisper reportActions (albeit from a while ago). Do you happen to know of anything that has changed recently in that logic?

Also asked in slack here in case anyone else has worked on that more recently.

[mountiny]

I think I have just run into something similar in staging https://expensify.slack.com/archives/C049HHMV9SM/p1721940861100039

[ishpaul777]

it appears type of orignalmessage is now a string which is causing crash

[ishpaul777]

actually the type of reportAction.message is string for ACTIONABLE_MENTION_WHISPER, originalMessage seems depriciated.

App/src/libs/ReportActionsUtils.ts

Lines 193 to 196 in 4c18661

	function getOriginalMessage<T extends ReportActionName>(reportAction: OnyxInputOrEntry<ReportAction<T>>): OriginalMessage<T> | undefined {
	if (!Array.isArray(reportAction?.message)) {
	return reportAction?.message ?? reportAction?.originalMessage;
	}

[ishpaul777]

Its a array on production server

[NikkiWines]

actually the type of reportAction.message is string for ACTIONABLE_MENTION_WHISPER, originalMessage seems depriciated.

originalMessage has been deprecated for a while now (since here)

But yeah if message is a string then definitely makes sense as the root for the issue

[francoisl]

I don't understand how originalMessage gets to be a string in the first place - can you tell if the stringified message you got here was returned by TrackExpense or something else?

I just tried the TrackExpense API from production and staging, and the backend returns the same format for both

{
  "key": "reportActions_2308535023239471",
  "onyxMethod": "merge",
  "value": {
    "983660383098354030": {
      "actionName": "ACTIONABLETRACKEXPENSEWHISPER",
      "actorAccountID": 8392101,
      "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/894b50e60056c966d12216005fbcacec8ce5a2c0.png",
      "created": "2024-07-25 21:41:48.670",
      "lastModified": "2024-07-25 21:41:48.670",
      "message": [
        {
          "html": "What would you like to do with this expense?",
          "text": "What would you like to do with this expense?",
          "type": "COMMENT",
          "whisperedTo": []
        }
      ],
      "originalMessage": {
        "html": "What would you like to do with this expense?",
        "lastModified": "2024-07-25 21:41:48.670",
        "transactionID": "4621430576663691334"
      },
      "person": [
        {
          "style": "strong",
          "text": "Expensify Concierge",
          "type": "TEXT"
        }
      ],
      "previousReportActionID": "3201231829538080024",
      "reportActionID": "983660383098354030",
      "shouldShow": true
    }
  }
}

[rlinoz]

It is from SearchForReports

"reportActions_8326091604995297": {
          "932416413244753707": {
            "action": "ACTIONABLETRACKEXPENSEWHISPER",
            "actorAccountID": 1,
            "actorEmail": "concierge@expensify.com",
            "created": "2024-07-25 20:56:55.686",
            "message": "{\"html\":\"What would you like to do with this expense?\",\"lastModified\":\"2024-07-25 20:56:55.686\",\"transactionID\":\"146406399869489744\"}",
            "reportActionID": 932416413244753700
          },

[rlinoz]

I think it is coming from here: https://github.com/Expensify/Web-Expensify/pull/42853/files#diff-7a032f7284c8b42392fb9715c5196b05b34ebeb369ee31387f702a26980eb792R6566

It works correctly in the OpenApp flow, but not in the SearchForReports

[francoisl]

Ooooh great find - you have to search for your own email to be able to reproduce.

That PR was deployed to production 6 hours ago and I can repro the crash on production too. We should probably revert it tbh.

[francoisl]

We're going to cherry-pick a backend fix for this to staging and production now.

Thanks @ishpaul777 and @rlinoz for helping look into this 🙌

[NikkiWines]

CP has installed on prod 👍

[NikkiWines]

@francoisl confirmed here that this resolved the issue 🎊 🚀 ❤️