-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty #46307
Comments
Triggered auto assignment to @marcochavezf ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Login - Incorrect error message "The given email is not valid." when login field is empty. What is the root cause of that problem?The login credentials are not available, which leads to sign in happening with a blank email. App/src/components/ValidateCode/ExpiredValidateCodeModal.tsx Lines 38 to 41 in c0f7868
What changes do you think we should make in order to solve the problem?If login data like email is not available, the the
|
@marcochavezf Since this is a deploy blocker, I can open the PR quickly. |
Sounds good, let's do it @ShridharGoel |
Job added to Upwork: https://www.upwork.com/jobs/~01c8fc425d7d2acad3 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann ( |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Update: PR is awaiting review. |
Hi @ShridharGoel, with any proposal for a deploy blocker, can you please include the PR from the current checklist that caused the regression? Thanks! |
Confirmed that #46314 fixed this issue in staging. Removing the blocker label. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Adding |
Triggered auto assignment to @johncschuster ( |
Acknowledged! I'll issue payment after the regression threshold is cleared. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Acknowledged! I'll issue payment after the regression threshold is cleared. |
@DylanDylann can you please complete the BZ list above? |
I have issued payment for @ShridharGoel. Thanks for your contributions! 🎉 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA Regression Test Proposal
Do we agree 👍 or 👎 |
I have issued payment for @DylanDylann. Thanks for your contributions! 🎉 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #45456
Action Performed:
)
Expected Result:
Since the login field is empty, the error message should be "Please enter an email or phone number"
Actual Result:
The error message is "The given email is not valid." when the login field is empty
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6553650_1721995908851.20240726_200630.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @johncschusterThe text was updated successfully, but these errors were encountered: