Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Sign in – Account settings page open when login with a new account using magic code #47055

Closed
4 of 6 tasks
IuliiaHerets opened this issue Aug 8, 2024 · 17 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4834070
Email or phone of affected tester (no customers): applausetester+jp_78824category@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter new Expensify email
  3. Open email and copy Magic code
  4. In Sign in page paste Magic code

Expected Result:

Inbox page opens

Actual Result:

Account settings page open

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565272_1723095032854.Account_settings_page_open_when_login_with_a_new_account.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0112e69610b7f6b0df
  • Upwork Job ID: 1821565963664006644
  • Last Price Increase: 2024-08-15
Issue OwnerCurrent Issue Owner: @hungvu193
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-vsb

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkuoch
Copy link
Contributor

nkuoch commented Aug 8, 2024

Tried with a gmail account and didn't have the bug. Reproduced the bug with an expensifail.com one, so it's linked to a beta

@nkuoch
Copy link
Contributor

nkuoch commented Aug 8, 2024

So, removing DeployBlocker, but this should be worked on!

@nkuoch nkuoch added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
@melvin-bot melvin-bot bot changed the title Sign in – Account settings page open when login with a new account using magic code [$250] Sign in – Account settings page open when login with a new account using magic code Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0112e69610b7f6b0df

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@hungvu193
Copy link
Contributor

Seems it was fixed here: #47099

Copy link

melvin-bot bot commented Aug 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
@hungvu193
Copy link
Contributor

Not overdue, asking for retest cc @JmillsExpensify

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@JmillsExpensify, @nkuoch, @hungvu193 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@hungvu193
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@JmillsExpensify
Copy link

Asked for a retest.

@JmillsExpensify
Copy link

Also filing this one in #wave-control since that is where the homepage is being worked on.

@m-natarajan
Copy link

Unable to reproduce now.

Screenrecorder-2024-08-20-17-51-55-256.mp4

@JmillsExpensify
Copy link

Closing based on the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants