LHN - App crashes after tap on any chat in LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4838537
Email or phone of affected tester (no customers): fischer9966+080824dadm@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open iOS App
2. Login with any account
3. Tap to any chat in LHN

Expected Result:

Chat opens correctly

Actual Result:

App crashes after tap on any chat in LHN

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

log_crash.txt

Bug6566315_1723174148428.iOS-App-Crashes-tap-chat-lhn.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[techievivek]

I am on the latest main, and I can't reproduce this. Is this already fixed?

[techievivek]

Screen.Recording.2024-08-09.at.6.09.08.PM.mov

Tried once again on lastest main, and couldn't reproduce it.

[techievivek]

Also, asked in #open-source channel to see if someone can reproduce it https://expensify.slack.com/archives/C01GTK53T8Q/p1723202882608139

[Beamanator]

A few people are experiencing this - https://expensify.slack.com/archives/C049HHMV9SM/p1723190961011019

But not sure if anyone has reproduced in main

[trjExpensify]

Thread discussion ongoing, @AndrewGable might have an idea.

[roryabraham]

PR with a fix is ready to go

[roryabraham]

this should be fixed in 9.0.18-8: https://github.com/Expensify/App/actions/runs/10323822881

[Beamanator]

Woohoo!! Working in staging again!

[m-natarajan]

Issue fixed

RPReplay_Final1723231189.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 🍒 Fix crash on staging #47180

If no regressions arise, payment will be issued on 2024-08-19. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@techievivek / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@techievivek / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@techievivek / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@techievivek / @roryabraham] Determine if we should create a regression test for this bug.
• [@techievivek / @roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[techievivek]

Going to close this since it's deployed to PROD and no payments or BZ checklist if required for this.