Distance rates - Offline indicator is not at the page bottom in Settings page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings.
3. Go to Distance rates.
4. Tap Settings.
5. Go offline.

Expected Result:

Offline indicator appears at the bottom of the page.

Actual Result:

Offline indicator is below the content.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571530_1723594292761.ScreenRecording_08-14-2024_04-34-18_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[jliexpensify]

@MonilBhavsar pretty sure this won't be a deploy blocker, right? This seems like a minor UI issue.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is below the content.

What is the root cause of that problem?

The wrapped View of this page doesn't have flexGrow style, it doesn't take the maximum height possible. Then the offline indicator display below the content instead of the bottom of the page

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 59 in b7f7f1b

const FullPageBlockingView = !customUnit ? FullPageOfflineBlockingView : View;

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Lines 98 to 99 in b7f7f1b

	<FullPageBlockingView>
	<ScrollView contentContainerStyle={styles.flexGrow1}>

What changes do you think we should make in order to solve the problem?

We should add flexGrow1 style when FullPageBlockingView is displayed as a View or we can move the ScrollView to outside FullPageBlockingView

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Lines 98 to 99 in b7f7f1b

	<FullPageBlockingView>
	<ScrollView contentContainerStyle={styles.flexGrow1}>

What alternative solutions did you explore? (Optional)

NA

[Krishna2323]

I think this is a regression from #43347

[jliexpensify]

Nice, ty @Krishna2323 - I'll assign @eVoloshchak, and luckily @MonilBhavsar was the engineer on that PR too

[MonilBhavsar]

@nkdengineer would you be please able to take a look

[nkdengineer]

I will raise the PR to fix this issue soon.

[MonilBhavsar]

Thank you!

[nkdengineer]

@eVoloshchak we have a follow PR here

[MonilBhavsar]

Thank you for the quick follow up! Appreciate it

[MonilBhavsar]

Issue is fixed. Thanks all!