-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance rates - Offline indicator is not at the page bottom in Settings page #47374
Comments
Triggered auto assignment to @jliexpensify ( |
Triggered auto assignment to @MonilBhavsar ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 2 |
@MonilBhavsar pretty sure this won't be a deploy blocker, right? This seems like a minor UI issue. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Offline indicator is below the content. What is the root cause of that problem?The wrapped
What changes do you think we should make in order to solve the problem?We should add
What alternative solutions did you explore? (Optional)NA |
I think this is a regression from #43347 |
Nice, ty @Krishna2323 - I'll assign @eVoloshchak, and luckily @MonilBhavsar was the engineer on that PR too |
@nkdengineer would you be please able to take a look |
I will raise the PR to fix this issue soon. |
Thank you! |
@eVoloshchak we have a follow PR here |
Thank you for the quick follow up! Appreciate it |
Issue is fixed. Thanks all! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Offline indicator appears at the bottom of the page.
Actual Result:
Offline indicator is below the content.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6571530_1723594292761.ScreenRecording_08-14-2024_04-34-18_1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: