Profile - Tapping on "Account name", shows interaction, but no redirection

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47338
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Pre: User does NOT have copilot enabled

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Go to Profile > Click on users name at the top

Expected Result:

User expects that if this is not a feature, then no interaction should happen

Actual Result:

The name is clickable (And blinks when clicked) and no redirect happens, when user has copilot enabled, the user can see a dropdown menu here

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6586051_1724900025751.No_account_to_switch_to_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on "Account name", shows interaction, but no redirection

What is the root cause of that problem?

By default we have a pressDimmingValue of 0.8 which is getting applied here

App/src/components/AccountSwitcher.tsx

Lines 122 to 131 in 8c69c58

	<PressableWithFeedback
	accessible
	accessibilityLabel={translate('common.profile')}
	onPress={() => {
	setShouldShowDelegatorMenu(!shouldShowDelegatorMenu);
	}}
	ref={buttonRef}
	interactive={canSwitchAccounts}
	wrapperStyle={[styles.flexGrow1, styles.flex1, styles.mnw0, styles.justifyContentCenter]}
	>

What changes do you think we should make in order to solve the problem?

We should pass a prop here pressDimmingValue and pass the value!canSwitchAccounts ? 1 : undefined

App/src/components/AccountSwitcher.tsx

Lines 122 to 131 in 8c69c58

	<PressableWithFeedback
	accessible
	accessibilityLabel={translate('common.profile')}
	onPress={() => {
	setShouldShowDelegatorMenu(!shouldShowDelegatorMenu);
	}}
	ref={buttonRef}
	interactive={canSwitchAccounts}
	wrapperStyle={[styles.flexGrow1, styles.flex1, styles.mnw0, styles.justifyContentCenter]}
	>

Instead of undefined we can also pass 0.8 here

What alternative solutions did you explore? (Optional)

we can also use !shouldShowDelegatorMenu here

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The name is clickable (And blinks when clicked) and no redirect happens, when user has copilot enabled, the user can see a dropdown menu here

What is the root cause of that problem?

Currently, we are using the PressableWithFeedback component to wrap the entire Switcher. Inside PressableWithFeedback, we have the OpacityView component which shows interaction even when the interactive prop is set to false.

What changes do you think we should make in order to solve the problem?

Update shouldDim here

App/src/components/Pressable/PressableWithFeedback.tsx

Line 52 in 8c69c58

shouldDim={!!(!rest.disabled && (isPressed || isHovered))}

    shouldDim={!!(!rest.disabled && (isPressed || isHovered) && rest.interactive)}

What alternative solutions did you explore? (Optional)

[rushatgabhane]

not a blocker. please assign me

this is under copilot project

[rushatgabhane]

cc @parasharrajat looks like we can't get rid of pressDimmingValue

[puneetlath]

demoting since copilot is in beta

[parasharrajat]

@rushatgabhane Maybe control the dimmingValue

[dangrous]

yeah i think just updating the dimming should satisfy this

[danieldoglas]

@rushatgabhane how's this one going?

[melvin-bot]

@danieldoglas, @OfstadC, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[danieldoglas]

@rushatgabhane bump!

[rushatgabhane]

fixed in draft PR above ^

[OfstadC]

Looks like this was deployed to production. So payment should be issued on 2024-09-26

[rushatgabhane]

@OfstadC this is part of copilot project. no payment due

[OfstadC]

Perfect! Thanks for confirming @rushatgabhane !