[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [$250] [Search v2.4] [App] Search Router List

[luacmartins]

Implement this section of the doc

cc @Kicu @289Adam289 @Guccio163 @SzymczakJ

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834649901147542101
• Upwork Job ID: 1834649901147542101
• Last Price Increase: 2024-09-13

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[joekaufmanexpensify]

SWM team, please comment on this issue if you're working on this one, and I will assign you!

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[joekaufmanexpensify]

TY!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834649901147542101

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

@SzymczakJ Is there an ETA for a PR for this one?

[SzymczakJ]

I'm just starting to work on it and it's hard to make estimates just now. I'll update tomorrow when I'll know more 🫡

[joekaufmanexpensify]

Sounds good. TY!

[SzymczakJ]

I should be able to put up a draft PR tomorrow!

[joekaufmanexpensify]

Sweet.

[SzymczakJ]

I've fixed the review comments and was about to record videos, but I've bumped into strange bug on iOS, which I'm solving at the moment. Probably the safe ETA would be next week 😓

[joekaufmanexpensify]

I see PR in review now. TY!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

I'm gonna close this issue in favor of #49116 since this PR handled both issues.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add recent serches and recent chats in Search router #49457
• Fix performance of SearchRouter #50143

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix performance of SearchRouter #50143

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.