Web - Workspace - No notification is received from the #Admin Room when creating workspace in OD

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4975714
Email or phone of affected tester (no customers): applausetester+shsbnotf@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Make sure that notifications is enabled in the device

1. Create a new Expensifail account in New Dot
2. Navigate to another tab and leave the New Expensify tab in the background
3. In the other tab navigate to OldDot (Log in with the same account that you signed in New Dot )
4. Create a Control or Collect policy - this will assign a Guide to the account for policy setup
5. Wait for a notification to be received from the #Admin Room

Expected Result:

A notification is received in the device from the #Admin Room

Actual Result:

A notification is not received in the device from the #Admin Room

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6607403_1726643037556.2024-09-18_10_01_34.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MariaHCD]

@IuliiaHerets could you clarify if the #admins room was actually created?

[MariaHCD]

Trying to reproduce the error, while the policy room was created the #admins room was not. I am not sure if that is the expected behavior. Additionally, the room only showed up after a refresh:

Screen.Recording.2024-09-18.at.6.15.51.PM.mov

[MariaHCD]

So I think we need to clarify what the expected behavior on ND when a workspace is created from OD cc: @mallenexpensify

But I don't think this should block the App deploy. The behavior is the same on prod, there is no #admins room created.

[IuliiaHerets]

@MariaHCD Tester can no longer repro the issue, it was fixed, build - v9.0.37-3

2024-09-18.22.37.36.mp4

[mallenexpensify]

there is no #admins room created.

I have an admin room created in NewDot for both staging and production tests. I don't see this message though

This is what I see

Because I'm not receiving the chat, I'm therefore not receiving the browser notification.

[MariaHCD]

Looks like the welcome messages that are sent in the SendAssignedGuideMessaging job wasn't received during @mallenexpensify's test.

I don't see a failed SendAssignedGuideMessaging job for that policyID.

@MonilBhavsar would you know why the SendAssignedGuideMessaging seemingly either wasn't queued or failed (and I can't find it) for the test above?

[MariaHCD]

@IuliiaHerets can we retest this so we can ensure it has been fixed?

[IuliiaHerets]

@MariaHCD Issue was fixed, not reproduced now

2024-09-23.16.00.14.mp4

[mallenexpensify]

Thanks @IuliiaHerets before closing, I'd like to get @MonilBhavsar 's 👀

@MonilBhavsar would you know why the SendAssignedGuideMessaging seemingly either wasn't queued or failed (and I can't find it) for the test above?

[MonilBhavsar]

Sorry missed it!

This is known and feature and not a bug.

In case of applause, we always assign QA guide. And since guide is assigned we queue SendAssignedGuideMessaging job.

In case of @mallenexpensify's case, since it was alias email, we didn't assign guide and hence no SendAssignedGuideMessaging job.

Code reference
https://github.com/Expensify/Web-Expensify/blob/445bdea689684e1d6842ec3ba435624f34b08017/lib/Policy/Utils.php#L1138-L1141

[MariaHCD]

Thanks for clarifying, @MonilBhavsar !

[mallenexpensify]

Thanks @MonilBhavsar !!