Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-30] [Debug Mode] Show reason for RBR/GBR on LHN tabs #49600

Open
puneetlath opened this issue Sep 23, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Sep 23, 2024

I would like to add a feature to the Debug Mode functionality, where if a user has an RBR or GBR on any of the three LHN tabs -- Inbox, Search, Account Settings -- we tell you what the reason is for that RBR/GBR being there.

For example, in this image, I have an RBR on the Inbox tab. I would like to be able to see what is causing that RBR.

image

Issue OwnerCurrent Issue Owner: @puneetlath
@puneetlath puneetlath added Weekly KSv2 NewFeature Something to build that is a new item. labels Sep 23, 2024
@puneetlath puneetlath self-assigned this Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Sep 23, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Sep 23, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@puneetlath
Copy link
Contributor Author

@dannymcclain un-assigning you since this is for debug mode, so I don't think there will be any UI considerations. But if there do end up being, I'll assign you back!

@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@pac-guerreiro
Copy link
Contributor

pac-guerreiro commented Sep 30, 2024

@puneetlath I'll open a PR soon for this! 😄

I'm currently working on getting the settings GBR/RBR causes and setting the logic to redirect users to what is triggering those GBR/RBR.

@DylanDylann
Copy link
Contributor

@puneetlath Could I help on this issue? because this may relate to previous PRs on the debug mode feature that I did before

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 14, 2024
@DylanDylann
Copy link
Contributor

@puneetlath please help confirm if this is what you expected. One more thing, If we have many GBR/RBR on LHN, which report should be prioritized to display on the below of LHN

Screenshot 2024-10-15 at 11 41 06

cc @pac-guerreiro

@puneetlath
Copy link
Contributor Author

I don't think it matters really in that scenario. Any one of them is fine.

@pac-guerreiro
Copy link
Contributor

Still waiting on final review from @DylanDylann

@pac-guerreiro
Copy link
Contributor

Waiting for someone to confirm translations on expensify-open-source 😄

@pac-guerreiro
Copy link
Contributor

The PR is ready to be merged! Thanks @Gonals for confirming the spanish translations and @DylanDylann for the review 🙌

@puneetlath let me know if you like the final result

@pac-guerreiro
Copy link
Contributor

The PR is finally merged with main 🙌

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot changed the title [Debug Mode] Show reason for RBR/GBR on LHN tabs [HOLD for payment 2024-10-30] [Debug Mode] Show reason for RBR/GBR on LHN tabs Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 23, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

4 participants