Investigate workflow job failing on main: test / test (job 2)

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: test / test (job 2)
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @nkdengineer
• 🤝 Merged by: @flodnv
• 🐛 Error Message:
  warning: The following actions use a deprecated Node.js version and will be forced to run on node20: SimenB/github-actions-cpu-cores@31e91de. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
  failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 2).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

[flodnv]

@nkdengineer any idea what's going on here? 😕

[nkdengineer]

@flodnv This is not a problem from our PR. This test also fails on the latest main.

[flodnv]

I asked here: https://expensify.slack.com/archives/C01GTK53T8Q/p1727173924473629

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates: I've prepared the Draft PR that fixes the test.
However I want to spend a little bit more time tomorrow to find out why the test has started to fail only lately to make sure that everything is correct.

[VickyStash]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The PaginationTest started to fail randomly on the main.
The reason for failing the test is that the part of newer report actions is not loaded:

What is the root cause of that problem?

A couple of days ago the PR, which updates the way new messages are loaded, was merged.

App/src/pages/home/report/ReportActionsList.tsx

Lines 617 to 619 in 48e9c17

	const onStartReached = useCallback(() => {
	InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadNewerChats(false)));
	}, [loadNewerChats]);

The InteractionManager.runAfterInteractions adds a small delay in the new messages loading which makes the test fail.

What changes do you think we should make in order to solve the problem?

Update the failing test to include the await waitForBatchedUpdatesWithAct(); after scrolling event to let the test wait for the new messages loading.

[VickyStash]

I've opened the PR for the review!
cc @flodnv @mountiny

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

This issue has not been updated in over 15 days. @flodnv, @VickyStash, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!