[HOLD for payment 2024-10-10] Android – Sign in – Able to dismiss the Onboarding modal using back button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5027336
Email or phone of affected tester (no customers): ponikarchuks+1311024@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. When Onboarding modal appears tap on back button on your device few times

Expected Result:

Onboarding modal present

Actual Result:

Onboarding modal disappears

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6621051_1727783731952.Signin.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[blazejkustra]

I think it is connected to #49586, do you know how we prevented this in the past? @allgandalf

[johnmlee101]

Bump @allgandalf !

[jasperhuangg]

This is a previous issue that is similar @johnmlee101 #47246

Although there it looks like they just retested and didn't experience it again so they closed it out :/

[johnmlee101]

Seems like an inconsistent issue. Think we should remove the blocker and just create an issue to fix?

[johnmlee101]

Or ask for a retest if someone has it up and ready?

[allgandalf]

Or ask for a retest if someone has it up and ready?

Lets ask for a retest and if not consistent then demote, c.c. @mountiny for vizz

[allgandalf]

Bump @allgandalf !

sorry got back just now. Looking....

[blazejkustra]

I have a fix for it 🥳 If you look closely at the video the onboarding modal was opened twice which allowed to dismiss the modal. Here is a video when onboarding modal is opened once:

Screen.Recording.2024-10-01.at.20.05.31.mov

[blazejkustra]

@johnmlee101 I was able to reproduce reliably on android, I would say it is a deploy blocker. PR ready here.

[allgandalf]

@johnmlee101 , I approved the PR, all yours now can you update the title of that PR to [CP Staging]. thanks

[johnmlee101]

Put the CP request

[jasperhuangg]

QA retest request here cc @Expensify/applause

[isagoico]

Issue is not reproducible on SG S10+ or Pixel6 🎉

video_2024-10-01_17-45-48.mp4

[mountiny]

No payments required here as the authors handled the fix, closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix that user was able to dismiss the onboarding modal on android #50015

If no regressions arise, payment will be issued on 2024-10-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@johnmlee101] The PR that introduced the bug has been identified. Link to the PR:
• [@johnmlee101] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@johnmlee101] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@johnmlee101] Determine if we should create a regression test for this bug.
• [@johnmlee101] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[alexpensify]

@johnmlee101 - is this notice accurate or a false alarm?

[johnmlee101]

Looks like a false alarm, I don't see the linked issue at all