Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Search - Edited currency is not updated until navigating out and returning to search #50004

Closed
1 of 6 tasks
IuliiaHerets opened this issue Oct 1, 2024 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5024245&group_by=cases:section_id&group_order=asc&group_id=296775
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on search on the bottom of the screen.
  3. Open any expense.
  4. Tap on the amount.
  5. Tap on the currency.
  6. Change the currency to USD.
  7. Tap on "Save"
  8. Tap on the arrow on the top left corner.
  9. Verify that the new currency was updated on the expense preview.

Expected Result:

Edited currency should be automatically updated on the expense preview on search.

Actual Result:

When the currency of an expense is updated on search section, it is not upadated on the expense preview until navigating out of search section and returning to it.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6621155_1727792212308.Currency.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 1, 2024
Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 1, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@luacmartins
Copy link
Contributor

Unable to reproduce on android mweb

@jasperhuangg jasperhuangg added Daily KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 1, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@Beamanator
Copy link
Contributor

oh shit i was just testing on android too and agree can't currently reproduce on android mweb 😅

@jasperhuangg
Copy link
Contributor

@Beamanator woops sorry about that, I also was unable to reproduce 😆

@Beamanator
Copy link
Contributor

no no you're good! i was slow 😬

@trjExpensify
Copy link
Contributor

Has anyone asked for an applause retest in #qa yet? CC: @IuliiaHerets

@Beamanator Beamanator added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Oct 3, 2024
@Beamanator
Copy link
Contributor

Nope, i haven't 😬 @IuliiaHerets can you please retest this when you get a chance? 🙏

@isagoico
Copy link

isagoico commented Oct 8, 2024

Issue was not reproduced on our side

3010593736917147526screen-20241007-233315.mp4

@trjExpensify
Copy link
Contributor

Okay, let's close this out then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Done
Development

No branches or pull requests

7 participants