[HOLD for payment 2024-10-11] [Guided Setup Stage 3] Onboarding message not sent when VBBA selected

[deetergp]

The original intent for the behavior of onboarding new users invited to NewDot by way of receiving an IOU or an Invoice was that we would send their onboarding message and tasks as soon as they chose to "Pay $n with Expensify" by either "Business bank account" or "Personal bank account" but when the feature was implemented, the calls to completeGuidedSetup were placed inside of IOU.payMoneyRequest and IOU.payInvoice. This is particularly important for users selecting Business bank account because that is a pretty onerous task and we want them to receive the onboarding tasks and message early, at the same time we create their workspace and move the IOU to an expense report.

Let's update this flow so that we complete their onboarding when they select the payment type.

cc @cdOut

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cdOut]

Hi, I'm Tymoteusz from Software Mansion and I worked on the guided setup 3 issues, you can assign me here and I'll raise a PR refactoring the VBBA flow.

[allgandalf]

Hey I reviewed the linked PR, please assign me here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[allgandalf]

The reported regression is a BE bug not FE we can ignore the above detail here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Guided Setup Stage 3] Onboarding message not sent when VBBA selected #50052

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @cdOut does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

Note

No checklist required here, it was change in design AFAIK, but still happy to provide if needed one

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @cdOut is from an agency-contributor and not due payment
• ROLE: @allgandalf paid $250 via Upwork

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[deetergp]

I agree, a regression checklist isn't needed.

[allgandalf]

Can you please pay this out @JmillsExpensify 🙇

[melvin-bot]

@deetergp, @JmillsExpensify, @cdOut, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

Not overdue sir melvin! 🙇

[JmillsExpensify]

Processing this one now.

[melvin-bot]

@deetergp, @JmillsExpensify, @cdOut, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@allgandalf apologies I forgot to actually send you the offer. Just did so, please let me know when you've accepted and I'll issue payment.

[allgandalf]

Haha, no worries at all, just accepted the offer 😄

[JmillsExpensify]

Haha mia culpa. All paid out, so closing this one!