[HOLD for payment 2024-10-25] Debug Mode - "Has RBR" is not shown for report that has RBR in LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: Unable to check Prod. There is no debug option in prod
Issue was found when executing this PR: #48442
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Enable "Debug mode" in troubleshoot
2. On home page, open a chat report from LHN that has a RBR
3. Click on the header of the chat you just opened, then click on Debug

Expected Result:

On the Details tab, "Has RBR" is shown in "Visible in LHN" for report that has RBR in LHN

Actual Result:

On the Details tab, "Has GBR" is shown instead of "Has RBR" in "Visible in LHN" for report that has RBR in LHN. For reports that has GBR "has GBR" is shown.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6628206_1728383227811.Screen_Recording_2024-10-08_at_1.05.39_in_the_afternoon.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

No need to be a deploy blocker because this feature is a troubleshooting tool

[mountiny]

@pac-guerreiro @DylanDylann Can you have a look please?

[pac-guerreiro]

@IuliiaHerets thanks for the bug report!

I missed the translation for hasRBR 😅 I'll add it and open a PR to fix this in the next hour or so 😄

[pac-guerreiro]

@mountiny

I made a mistake while resolving merge conflicts so this issue still persists. Is it okay if I resolve it here - #50831 ?

[DylanDylann]

@pac-guerreiro What is the mistake that you mentioned above?

[pac-guerreiro]

@DylanDylann

Nevermind, I got the merge conflict on #50831 and had to change the logic a bit for this fix to work there! I just thought that I had missed something on this issue during the final rebase with main, but that's not the case!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Debug Mode - "Has RBR" is not shown for report that has RBR in LHN #50468

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @pac-guerreiro is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[adelekennedy]

Payouts due:

• Reviewer: $250 @DylanDylann Offer sent!

[adelekennedy]

@DylanDylann bump also on the checklist

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: #48442
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Just discussed with the author
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Enable Debug mode in troubleshoot
2. On home page, open a chat report from LHN that has a RBR
3. Click on the header of the chat you just opened, then click on Debug
4. On the Details tab, Has RBR is shown in Visible in LHN for report that has RBR in LHN

Do we agree 👍 or 👎

[melvin-bot]

@mountiny, @pac-guerreiro, @adelekennedy, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?