[HOLD for payment 2024-10-24] Tags - Long pressing North+east not showing settings option

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Launch app
2. In old dot, upload dependent tags
3. In new dot, open workspace settings
4. Open tags
5. Tap region
6. Long press North+east

Expected Result:

Pressing "select" after long pressing the North+east tag triggers selection mode.

Actual Result:

Pressing "select" after long pressing the North+east tag doesn't trigger selection mode.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6630271_1728534159671!Dependent_-_Multi_Level_tags_NEW.csv

Bug6630271_1728529080295.Screenrecorder-2024-10-10-08-23-52-928_compress_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mjasikowski]

Checking this one out right now

[mjasikowski]

@IuliiaHerets I've edited the description, as it took me a while to understand what should be happening and what's not happening.

[mjasikowski]

The issue is caused by #49510

[daledah]

@mjasikowski I'll open a follow-up PR soon.

[mjasikowski]

Revert cherry picked to staging

[daledah]

@mjasikowski Here's the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: header flickering on selection mode and fix regressions #50705

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mjasikowski] The PR that introduced the bug has been identified. Link to the PR: fix: search header flickering on selection mode #49510
• [@mjasikowski] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: search header flickering on selection mode #49510 (comment)
• [@mjasikowski] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@daledah] Determine if we should create a regression test for this bug.
• [@daledah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mjasikowski]

@daledah since you have more information, can you comment in the original PR letting us know what exactly caused the issue in question?

[daledah]

@mjasikowski I commented here: #49510 (comment)

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

Processing

[greg-schroeder]

This was a regression fixed by the original contributor of the offending PR

[melvin-bot]

@mjasikowski @greg-schroeder Be sure to fill out the Contact List!