Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal that shows European countries list is not being shown #51385

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 24, 2024 · 5 comments
Closed
2 of 8 tasks

Modal that shows European countries list is not being shown #51385

IuliiaHerets opened this issue Oct 24, 2024 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR:
Email or phone of affected tester (no customers): #51173
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace
  3. Change the workspace currency to EUR, GBP, CAD or AUD
  4. Go to more features and enable workflows
  5. Go to workflows and click on connect bank account

Expected Result:

New component with European countries list gets shown.

Actual Result:

No new component with European countries list gets shown but the usual "Update currency to USD" modal gets shown

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6643733_1729716879087.bandicam_2024-10-23_23-47-34-363.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Oct 24, 2024

Hey, I'm the creator of the PR. We're building a flow for global reimbursements that will support adding bank account for workspaces with different currency than USD - #50896. At the moment this whole feature is accessible in development mode only. I can try to find out if there is something we can do to make this flow accessible by QAs right now if there is such need. I'm not 100% that there is such need at the moment as we're building it piece by piece and it won't be fully operational until phase 4. There will be a moment when we will want to make it accessible by everyone and at this point it will be of course tested as a whole.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Oct 24, 2024

I can make it visible in debug mode. I believe it's not a big effort and would allow you QAs to check this.

@CortneyOfstad
Copy link
Contributor

Thanks for @MrMuzyk! I agree that this is not needed right now, so going to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants