Tags - App returns to tag page after tapping back button on workspace editor

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123688
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has imported dependent tags (attached below).

1. Launch ND or hybrid app.
2. Go to workspace settings > Tags.
3. Tap on any main tag.
4. Tap app back button to go back to main tag page.
5. Tap app back button to return to workspace editor.
6. Tap app back button again.

Expected Result:

App will return to workspace list

Actual Result:

App returns to tag page after tapping back button on workspace editor.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6644449_1729774664725.iOS.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[Julesssss]

Regression, but not a blocker. Removing label.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - App returns to tag page after tapping back button on workspace editor

What is the root cause of that problem?

We pass fallback route when going back which push new stack navigator

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Line 276 in 66112d1

Navigation.goBack(isQuickSettingsFlow ? ROUTES.SETTINGS_TAGS_ROOT.getRoute(policyID) : ROUTES.WORKSPACE_TAGS.getRoute(policyID));

What changes do you think we should make in order to solve the problem?

We should remove the fallback route

What alternative solutions did you explore? (Optional)

We can can pass backTo as the fallback route

Navigation.goBack(backTo)

[kadiealexander]

Reassigning as I'm OOO for the next two weeks.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.