Enable HybridApp test builds in App repo

[Julesssss]

Problem

During PR review we perform test only against ND while the users will use Hybrid App. It prevent us from finding possible bugs and problem users will face.

P/S from Jan here

Solution

Let's configure our CI/CD so it's possible to trigger AdHoc build of Hybrid App from ND repo.

[jnowakow]

Hello, I'm from SoftwareMansion and I'll work on this

[jnowakow]

@Julesssss I managed to successfully add new build type for Android and new scheme for iOS - here's draft PR.
The next step requires action from someone who has access to Firebase console and developer profile because I think it's time to generate new google-services.json, GoogleService-info.plist and create new provisioning profile.

I think that bundle id's are required for that configuration so I propose:
iOS:
com.expensify.expensifylite - Release
com.expensify.expensifylite.debug - Debug
com.expensify.expensifylite.adhoc - AdHoc

Android:
org.me.mobiexpensifyg - release
org.me.mobiexpensifyg.debug - debug
org.me.mobiexpensifyg.adhoc - adhoc

Please let me know if I should provide some additional info and when this can be accomplished

[Julesssss]

Hey, sorry for the delay! I will make time for this as soon as possible. No extra details required yet.

[jnowakow]

No problem, I've started to work on other things in the meantime :)

[Julesssss]

Sorry for the delay here, I'll have time to review tomorrow!

[Julesssss]

Hey @jnowakow, I can generate the Firebase apps. I'm thinking we should do .dev instead of .debug to align with Expensify/App, and to make it clear that these are dev builds.

Let me know if you see any problems with this

[Julesssss]

I have configured the iOS/Android apps in Firebase (using .dev). I haven't yet added the Android SHA certificate fingerprints, so Google SSO and other things won't work. But I think that is fine.

@jnowakow I will DM you the google services files.

[jnowakow]

@Julesssss I .dev instead of .debug is great for me. Thanks for taking care of it!

[Julesssss]

Hey @jnowakow, we've been chatting 1:1 but could you share an update on this issue please?

[jnowakow]

Sure!
Last update is that everything seems to work fine with provided firebase configurations. In order to proceed with iOS I'll need new provisioning profile, notification service profile and certificates. For Android I think I don't need any additional set up so I'll focus right now on creating GH workflow

[jnowakow]

@Julesssss here are the current changes:
old dot
new dot
I think everything is in place to test if android adhoc build is working fine

[Julesssss]

Nice, I will take a look.

I assume we need to merge Mobile-Expensify first? If so can we put a hold on the App PR? And mark Mobile-Expensify as ready for review. I can also try to run a test build against this branch if we are ready.

[jnowakow]

Thanks for review! I've answered the comments and addressed those two little TODOs.
In general yes, I think we would have to merge OD first but iOS is not 100% ready (I think nothing should break). I'm also afraid that we have to merge this PR in order to be able to run this workflow

[Julesssss]

I added/updated the AdHoc iOS profiles in 1Password. Shared names with Jan.

[Julesssss]

Initial iOS PR was merged, once deployed we can kick off a test build.

[Julesssss]

Another PR here to apply changes necessary due to our submodule changes.

[Julesssss]

• Error with Android HybridApp build
  • Sounds similar to a fix we made here
• Error with iOS HybridApp build
  • OldApp_AdHoc with 1Pass filename

[jnowakow]

Here are results from workflow run after updating it with new repos structure. Android failed because the branch is not in sync with main. It's because Fastfile on the brach doesn't contain necessary changes. Android should work fine on branches that are in sync with newest main.
On iOS there was problem with getting documents from 1Password. @Julesssss could you check if you are able to run this commands locally?

op document get --output ./OldApp_AdHoc.mobileprovision OldApp_AdHoc
op document get --output ./OldApp_AdHoc_Share_Extension.mobileprovision OldApp_AdHoc_Share_Extension
op document get --output ./OldApp_AdHoc_Notification_Service.mobileprovision OldApp_AdHoc_Notification_Service

[Julesssss]

Hi @jnowakow, yep all three of these work correctly for me. Modifying the names causes errors.

[jnowakow]

Hmm then I don't know where the problem is 🤔 I copied those commands from workflow so I don't know where I could do the typo

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Update workflow to build and publish to S3 ios adhoc hybrid app #53850

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @jnowakow does not require payment (Contractor)

[jnowakow]

@Julesssss
I see plan for proceeding with this issue as follows:

Merge PR with changes for iOS in OD. I've merged newest main and adjusted it to new repo structure. I've tested it locally and all three schemas seems to work fine.

Figure out why 1Password doesn't see apple related files that you added recently. I'm afraid I need you help here because I don't have access to 1Pass. Can you check if those files are added in the same way as other files (eg. upload-key.keystore for Android)? Maybe they have to be exported or something like that?

Figure out why validateActor is failing. I suspect it was some random issue and if we rerun the workflow this step should pass. This step wasn't modified in the meantime and was working fine before. It's also the same as in other workflows (eg. here) and there it isn't failing. If we rerun the workflow and is keeps failing then I have to investigate it.

I think that on ND side almost everything is ready. There are small corrections to do like fixing the typo in workflow name or running dev scheme when launching from terminal.

[Julesssss]

Merge PR with changes for iOS in https://github.com/Expensify/Mobile-Expensify/pull/13297

Reviewing now 👍

Can you check if those files are added in the same way as other files (eg. upload-key.keystore for Android)? Maybe they have to be exported or something like that?

Sure, I am rushing to finish some things before going OOO but I can help with that in the new year

Figure out why validateActor is failing. I suspect it was some random issue and if we rerun the workflow this step should pass

Also sounds good