-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mWeb - Expense - Renamed the report system message is shown incorrectly. #53820
Comments
Triggered auto assignment to @jliexpensify ( |
Production ScreenRecording_12-10-2024.13-36-20_1.MP4 |
@IuliiaHerets is this an actual Deploy Blocker, or did you accidentally use the label? |
@jliexpensify No, I added the label on purpose. Issue was reproduced in stg and prod with staging server off, issue was not repro with SS on. Screenrecorder-2024-12-10-18-49-03-770.mp4 |
Production @jliexpensify Screenrecorder-2024-12-10-18-57-16-578.mp4 |
Clarifying if this is a true deploy blocker here |
Triggered auto assignment to @francoisl ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Hi @francoisl - Applause seems to think this is a deploy blocker, but I don't think it is (and I can't repro). Puneet advised applying both labels here. |
I can repro on Web on staging, looking now. Not sure if it's a backend or NewDot blocker yet, let's keep both labels for now. |
This is a backend bug caused by https://github.com/Expensify/Web-Expensify/pull/44662/, removing the NewDot blocker label. |
I think the revert of https://github.com/Expensify/Web-Expensify/pull/44662 worked and we're good to remove the blocker label. 2024-12-11_10-08-59.mp4 |
Asked Applause for a retest here https://expensify.slack.com/archives/C9YU7BX5M/p1733940322271419?thread_ts=1733940210.713079&cid=C9YU7BX5M |
We cherry-picked a backend fix https://github.com/Expensify/Web-Expensify/pull/44733. Both Scott and I confirmed the regression is no longer on staging, removing the blocker label. |
Awesome, are we good to close this @francoisl @deetergp ? |
Looks that way @jliexpensify. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: V9. 0.73-6
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Renamed the report system message must not be shown.
Actual Result:
Renamed the report system message is shown incorrectly.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6689697_1733811792457.Screenrecorder-2024-12-10-11-46-13-39.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: