Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Expense - Renamed the report system message is shown incorrectly. #53820

Closed
1 of 8 tasks
IuliiaHerets opened this issue Dec 10, 2024 · 19 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9. 0.73-6
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Open a workspace chat
  3. Create a expense
  4. Open the expense

Expected Result:

Renamed the report system message must not be shown.

Actual Result:

Renamed the report system message is shown incorrectly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6689697_1733811792457.Screenrecorder-2024-12-10-11-46-13-39.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 10, 2024
@IuliiaHerets
Copy link
Author

Production

ScreenRecording_12-10-2024.13-36-20_1.MP4

@jliexpensify
Copy link
Contributor

@IuliiaHerets is this an actual Deploy Blocker, or did you accidentally use the label?

@jliexpensify
Copy link
Contributor

I can't repro on staging or prod v73-6 (Pixel 7) - closing:

Screenshot_20241210-204807

@IuliiaHerets
Copy link
Author

@jliexpensify No, I added the label on purpose. Issue was reproduced in stg and prod with staging server off, issue was not repro with SS on.
QA team can still repro this issue

Screenrecorder-2024-12-10-18-49-03-770.mp4

@IuliiaHerets IuliiaHerets reopened this Dec 10, 2024
@IuliiaHerets
Copy link
Author

Production @jliexpensify

Screenrecorder-2024-12-10-18-57-16-578.mp4

@jliexpensify
Copy link
Contributor

Clarifying if this is a true deploy blocker here

@jliexpensify jliexpensify added the DeployBlockerCash This issue or pull request should block deployment label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 10, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jliexpensify
Copy link
Contributor

Hi @francoisl - Applause seems to think this is a deploy blocker, but I don't think it is (and I can't repro). Puneet advised applying both labels here.

@francoisl
Copy link
Contributor

I can repro on Web on staging, looking now. Not sure if it's a backend or NewDot blocker yet, let's keep both labels for now.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2024
@francoisl
Copy link
Contributor

This is a backend bug caused by https://github.com/Expensify/Web-Expensify/pull/44662/, removing the NewDot blocker label.

@deetergp
Copy link
Contributor

I think the revert of https://github.com/Expensify/Web-Expensify/pull/44662 worked and we're good to remove the blocker label.

2024-12-11_10-08-59.mp4

@deetergp
Copy link
Contributor

@deetergp deetergp removed the DeployBlocker Indicates it should block deploying the API label Dec 11, 2024
@francoisl
Copy link
Contributor

We cherry-picked a backend fix https://github.com/Expensify/Web-Expensify/pull/44733. Both Scott and I confirmed the regression is no longer on staging, removing the blocker label.

@jliexpensify jliexpensify added Daily KSv2 and removed Hourly KSv2 labels Dec 12, 2024
@mvtglobally
Copy link

Not reproducible https://github.com/user-attachments/assets/6abac4a3-59a5-4641-b3b5-017a2f02a20c

@jliexpensify
Copy link
Contributor

Awesome, are we good to close this @francoisl @deetergp ?

@deetergp
Copy link
Contributor

Looks that way @jliexpensify. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants