Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] [$250] Track distance - Not here page opens after submitting track distance expense to new workspace #53995

Closed
5 of 8 tasks
IuliiaHerets opened this issue Dec 12, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): dnfioffdjojdfoidfjod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has no workspace (new account).
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a distance expense.
  4. Click Share it with my accountant.
  5. Click Rate.
  6. Select any rate.
  7. Click Submit.

Expected Result:

The track distance expense is submitted to the workspace chat.

Actual Result:

Not here page opens after submitting track distance expense to a new workspace.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6691881_1733990287565.20241212_155552.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021867171525628939701
  • Upwork Job ID: 1867171525628939701
  • Last Price Increase: 2024-12-12
Issue OwnerCurrent Issue Owner: @mallenexpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

Julesssss commented Dec 12, 2024

I believe this is the backend error, though it's possible a separate error:

Screenshot 2024-12-12 at 10 30 09

UpdateMoneyRequestDistanceRate fails because customUnitRateID is passed, but is missing necessary fields. The transactionNVPs json must include customUnit and customUnit.name must be `Distance.

@Julesssss
Copy link
Contributor

I'm not seeing any recent changes on the backend. There is a single App PR on the checklist related to distance customUnits, which I have commented on.

@paultsimura
Copy link
Contributor

@Julesssss, I see this happens only in the no-workspace case when a new one is created automatically.
We never pass the customUnit.name in other API params and when sharing to an existing workspace, the flow works well, so I doubt this can be fixed on FE.

For my PR, a BE change was made previously – Web-E 44237. Could you please check maybe it's not handling this case correctly?

cc: @neil-marcellini

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Dec 12, 2024
@melvin-bot melvin-bot bot changed the title Track distance - Not here page opens after submitting track distance expense to new workspace [$250] Track distance - Not here page opens after submitting track distance expense to new workspace Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021867171525628939701

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@Julesssss
Copy link
Contributor

Thanks @paultsimura. That backend PR only modified tests unfortunately, so I don't think that can be the cause.

@paultsimura
Copy link
Contributor

I don't know what transactionNVPs is or why UpdateMoneyRequestDistanceRate is triggered — I only call the ShareTrackedExpense API command from the FE. In my PR, we started passing the customUnitRateID to that API endpoint.

Maybe the BE doesn't handle it correctly when both conditions are met:

  1. The customUnitRateID param is present
  2. The workspace is a newly created one (why should it matter for the BE?)

Let me wait for @neil-marcellini and maybe we'll figure this out 👀

@shubham1206agra
Copy link
Contributor

@paultsimura Maybe this is same as #51035

@paultsimura
Copy link
Contributor

Great point @shubham1206agra – these 2 indeed look related.
@Julesssss, I see you wrote on the original GH that the BE change may not be prioritized soon. Maybe this use case can help bump it up?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 12, 2024
@neil-marcellini
Copy link
Contributor

neil-marcellini commented Dec 12, 2024

Thanks @paultsimura. That backend PR only modified tests unfortunately, so I don't think that can be the cause.

@Julesssss It's linked to an Auth PR, which did make changes. @paultsimura sounds like we're going to revert this one since the error isn't reproducible on production, but is after our PR. The problem might very well be on the backend but this way it's not possible for users to encounter it until we fix it.

Would you please explain the root cause on the original issue. Any idea what's causing a problem on the backend or what error is returned? I haven't investigated myself yet but I can later.

@Julesssss
Copy link
Contributor

Requested a retest here.

@isagoico
Copy link

Retest was a pass!

Untitled.video.6.mp4

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Dec 13, 2024
@Julesssss
Copy link
Contributor

Removing blocker

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title [$250] Track distance - Not here page opens after submitting track distance expense to new workspace [HOLD for payment 2024-12-20] [$250] Track distance - Not here page opens after submitting track distance expense to new workspace Dec 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 13, 2024

@shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants