Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-30] Search (Chats) - Extra left and right padding, entire row is not highlighted when hovered #54121

Closed
6 of 8 tasks
lanitochka17 opened this issue Dec 13, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/S
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search
  3. Go to Chats
  4. Hover over any message

Expected Result:

  • Each message item in Chats will not have extra left and right padding
  • When hovering over the message, the entire row will be highlighted

Actual Result:

  • Each message item in Chats has extra left and right padding
  • When hovering over the message, the entire row is not highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6693645_1734111214738.20241213_235032.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 13, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:

bandicam.2024-12-13.19-44-46-674.mp4

@luacmartins
Copy link
Contributor

Potential suspect #53482 @marcochavezf @FitseTLT @mananjadhav

@FitseTLT
Copy link
Contributor

Yep will take a 👀 into it please assign me @lucamartins

@luacmartins
Copy link
Contributor

Thanks @FitseTLT. Let me know if I can help

@luacmartins
Copy link
Contributor

any luck @FitseTLT?

@FitseTLT
Copy link
Contributor

still digging will hope fully raise a fix in a few hours 👍

@FitseTLT
Copy link
Contributor

But confirmed it is caused by my PR

@FitseTLT
Copy link
Contributor

Raised the fix @luacmartins

@luacmartins
Copy link
Contributor

Fix being CPed

@mananjadhav
Copy link
Collaborator

Thanks @luacmartins @FitseTLT. I was offline

@luacmartins
Copy link
Contributor

Fixed in staging.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Dec 16, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 23, 2024
@melvin-bot melvin-bot bot changed the title Search (Chats) - Extra left and right padding, entire row is not highlighted when hovered [HOLD for payment 2024-12-30] Search (Chats) - Extra left and right padding, entire row is not highlighted when hovered Dec 23, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

  • @FitseTLT requires payment (Needs manual offer from BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants