Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Chat - Composer menu still contains "Submit expense" option #54129

Closed
1 of 8 tasks
IuliiaHerets opened this issue Dec 13, 2024 · 7 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue was found when executing this PR: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53385
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.0
App Component: Chat Report View

Action Performed:

  1. Open the app
  2. Log in with a Gmail account
  3. Open any 1:1 DM
  4. Click on the "+" button on the composer

Expected Result:

It should be "Create expense".

Actual Result:

Composer menu still contains "Submit expense" option. FAB displays "Create expense" correctly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6693772_1734118665388.Screen_Recording_2024-12-13_At_11.31.21.mp4

Bug6693772_1734118649526!Capture

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mallenexpensify mallenexpensify added the Needs Reproduction Reproducible steps needed label Dec 14, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@mallenexpensify
Copy link
Contributor

Will look into next week, trying to get to the source of where we decided on the change that's listed as the expected behaviour in the OP.

SIDE NOTE: I've used Needs Reproduction as a 'hold' before adding to a project. That shouldn't be a best practice now that the label auto-posts in #contributor-plus to see if a C+ can reproduce. Need to do something there too

@s77rt
Copy link
Contributor

s77rt commented Dec 14, 2024

I can reproduce (same steps as OP) but not sure if this is a bug

@mallenexpensify
Copy link
Contributor

Same @s77rt , will update next week

@mananjadhav
Copy link
Collaborator

It's not a bug. We only cleaned up the FAB for Submit Expense. The rest of the cleanup at other places including the composer will be handled here #54006. @mallenexpensify I think we're good to close this one.

@mallenexpensify
Copy link
Contributor

Thx @mananjadhav , closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants